You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/12 13:04:00 UTC

[GitHub] [kafka] showuon opened a new pull request #11206: MINOR: Update streams doc to close KeyValueIterator in example code

showuon opened a new pull request #11206:
URL: https://github.com/apache/kafka/pull/11206


   Update the streams doc:
   1. close `KeyValueIterator` in example code
   <img width="1093" alt="image" src="https://user-images.githubusercontent.com/43372967/129201334-326ff4f9-e06e-426d-9d2d-ce70e13cbf9c.png">
   
   2. Fix the example code indent
   <img width="1068" alt="image" src="https://user-images.githubusercontent.com/43372967/129201406-632b62a5-9062-4a1f-b529-103f92966541.png">
   
   
   3. Add missing comma between key/value
   <img width="746" alt="image" src="https://user-images.githubusercontent.com/43372967/129201511-e69b6225-9e8c-4f08-b9a2-615aee21e52b.png">
   
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11206: MINOR: Update streams doc to close KeyValueIterator in example code

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11206:
URL: https://github.com/apache/kafka/pull/11206#issuecomment-912194561


   @bbejeck , please take a look when available. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11206: MINOR: Update streams doc to close KeyValueIterator in example code

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11206:
URL: https://github.com/apache/kafka/pull/11206#issuecomment-927600535


   @bbejeck, please help review. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11206: MINOR: Update streams doc to close KeyValueIterator in example code

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11206:
URL: https://github.com/apache/kafka/pull/11206#issuecomment-897622337


   @bbejeck , please help review. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org