You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/11/15 15:34:47 UTC

[GitHub] [storm] agresch commented on a change in pull request #3167: STORM-3538 Add Meter for sendSupervisorAssignments exception

agresch commented on a change in pull request #3167: STORM-3538 Add Meter for sendSupervisorAssignments exception
URL: https://github.com/apache/storm/pull/3167#discussion_r346877645
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
 ##########
 @@ -1654,6 +1657,10 @@ private AssignmentDistributionService getAssignmentsDistributer() {
         return assignmentsDistributer;
     }
 
+    private StormMetricsRegistry getMetricsRegistry() {
 
 Review comment:
   This seems redundant since it is private.  Any real reason for having this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services