You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/13 11:39:23 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10300: fix(chart-data-api): improve chart data endpoint errors
codecov-commenter commented on pull request #10300:
URL: https://github.com/apache/incubator-superset/pull/10300#issuecomment-657509276
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10300?src=pr&el=h1) Report
> Merging [#10300](https://codecov.io/gh/apache/incubator-superset/pull/10300?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93753cf2f8a4164a3631320eba088844630dc57c&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10300?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10300 +/- ##
==========================================
+ Coverage 70.42% 70.58% +0.16%
==========================================
Files 599 599
Lines 32067 32083 +16
Branches 3244 3245 +1
==========================================
+ Hits 22583 22646 +63
+ Misses 9380 9333 -47
Partials 104 104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.53% <0.00%> (+0.06%)` | :arrow_up: |
| #javascript | `59.57% <0.00%> (-0.01%)` | :arrow_down: |
| #python | `69.76% <83.33%> (+0.26%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10300?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `65.30% <0.00%> (-1.37%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `73.19% <75.00%> (+0.03%)` | :arrow_up: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `80.12% <100.00%> (+0.38%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.95% <0.00%> (+0.14%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.64% <0.00%> (+0.24%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.98% <0.00%> (+0.28%)` | :arrow_up: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (+0.95%)` | :arrow_up: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.98% <0.00%> (+1.65%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/10300/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10300?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10300?src=pr&el=footer). Last update [93753cf...f7f4c1b](https://codecov.io/gh/apache/incubator-superset/pull/10300?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org