You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by marchpig <gi...@git.apache.org> on 2016/12/15 16:46:43 UTC
[GitHub] zeppelin pull request #1771: [ZEPPELIN-1820] Fix action bar layout broken is...
GitHub user marchpig opened a pull request:
https://github.com/apache/zeppelin/pull/1771
[ZEPPELIN-1820] Fix action bar layout broken issue
### What is this PR for?
Action bar buttons and paragraph are overlapped when the browser width is small.
To fix this issue, this PR replaces `height` css property for action bar with `min-height` and adds a binding code for `window resize` to dynamically change the paragraph position based on the height of action bar.
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1820
### How should this be tested?
Change browser width
### Screenshots (if appropriate)
[Before]
[After]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1771.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1771
----
commit 01e2a9841a981d2dea454de1f67e849e2f2dc71d
Author: Sangwoo Lee <ma...@gmail.com>
Date: 2016-12-15T16:27:49Z
Fix action bar layout broken issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1771: [ZEPPELIN-1820] Fix action bar layout broken issue
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1771
Tested and works great.
Thanks @marchpig for the fix.
Merge to master if there're no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1771: [ZEPPELIN-1820] Fix action bar layout broken issue
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1771
Tested and It works well!
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1771: [ZEPPELIN-1820] Fix action bar layout broken is...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1771
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---