You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by jo...@apache.org on 2008/03/31 05:48:37 UTC
svn commit: r642866 - in /cocoon/branches/BRANCH_2_1_X:
src/blocks/forms/java/org/apache/cocoon/forms/formmodel/tree/Tree.java
status.xml
Author: joerg
Date: Sun Mar 30 20:48:37 2008
New Revision: 642866
URL: http://svn.apache.org/viewvc?rev=642866&view=rev
Log:
COCOON-2178: Forms: Dispatch only one TreeSelectionEvent on multiple selection rather than one event for each selected tree item.
Modified:
cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/tree/Tree.java
cocoon/branches/BRANCH_2_1_X/status.xml
Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/tree/Tree.java
URL: http://svn.apache.org/viewvc/cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/tree/Tree.java?rev=642866&r1=642865&r2=642866&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/tree/Tree.java (original)
+++ cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/tree/Tree.java Sun Mar 30 20:48:37 2008
@@ -16,9 +16,11 @@
*/
package org.apache.cocoon.forms.formmodel.tree;
+import java.util.Arrays;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
+import java.util.List;
import java.util.Locale;
import java.util.Set;
@@ -198,6 +200,11 @@
getForm().addWidgetUpdate(this);
}
+ private void markForRefresh(List paths) {
+ this.changedPaths.addAll(paths);
+ getForm().addWidgetUpdate(this);
+ }
+
//---------------------------------------------------------------------------------------------
// Selection
//---------------------------------------------------------------------------------------------
@@ -269,11 +276,15 @@
if (this.selectionModel == SINGLE_SELECTION) {
setSelectionPath(paths[0]);
} else {
- for (int i = 0; i < paths.length; i++) {
- addSelectionPath(paths[i]);
- // FIXME: use array-based constructors of TreeSelectionEvent
+ List pathsList = Arrays.asList(paths);
+ if (this.selectedPaths.addAll(pathsList)) {
+ markForRefresh(pathsList);
+ if (this.expandSelectedPath) {
+ this.expandedPaths.addAll(pathsList);
+ }
+ this.getForm().addWidgetEvent(new TreeSelectionEvent(this, paths, true));
}
- }
+ }
}
public void removeSelectionPath(TreePath path) {
@@ -285,9 +296,10 @@
}
public void removeSelectionPaths(TreePath paths[]) {
- for (int i = 0; i < paths.length; i++) {
- removeSelectionPath(paths[i]);
- // FIXME: use array-based constructors of TreeSelectionEvent
+ List pathsList = Arrays.asList(paths);
+ if (this.selectedPaths.removeAll(pathsList)) {
+ markForRefresh(pathsList);
+ this.getForm().addWidgetEvent(new TreeSelectionEvent(this, paths, false));
}
}
Modified: cocoon/branches/BRANCH_2_1_X/status.xml
URL: http://svn.apache.org/viewvc/cocoon/branches/BRANCH_2_1_X/status.xml?rev=642866&r1=642865&r2=642866&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/status.xml (original)
+++ cocoon/branches/BRANCH_2_1_X/status.xml Sun Mar 30 20:48:37 2008
@@ -182,6 +182,9 @@
<changes>
<release version="2.1.12" date="TBD">
+ <action dev="JH" type="fix" fixes-bug="COCOON-2178" due-to="Harald Entner" due-to-email="harald.entner@workflow.at">
+ Forms: Dispatch only one TreeSelectionEvent on multiple selection rather than one event for each selected tree item.
+ </action>
<action dev="JH" type="fix" fixes-bug="COCOON-2109" due-to="Miguel Cuervo" due-to-email="miguel.cuervo@cgi.com">
Core: Fix clean up of continuations.
</action>
@@ -241,7 +244,7 @@
</release>
<release version="2.1.11" date="December 31 2007">
<action dev="RG" type="fix" fixes-bug="COCOON-1574">
- Created XPathXMLFileModule to address issus with XMLFileModule. XPathXMLFileModule supports variable
+ Created XPathXMLFileModule to address issues with XMLFileModule. XPathXMLFileModule supports variable
replacement and caching of documents in ehcache and expressions as soft references.
</action>
<action dev="AG" type="fix" fixes-bug="COCOON-2052" due-to="Robin Wyles" due-to-email="rob@robinwyles.com">