You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/13 08:12:26 UTC
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4397: List VMs by Security Group & HA
GabrielBrascher commented on a change in pull request #4397:
URL: https://github.com/apache/cloudstack/pull/4397#discussion_r503752859
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1016,10 +1024,18 @@
sc.setParameters("serviceOfferingId", serviceOffId);
}
+ if(securityGroupId != null) {
+ sc.setParameters("securityGroupId", securityGroupId);
+ }
+
if (display != null) {
sc.setParameters("display", display);
}
+ if (display != null) {
Review comment:
The code has been updated addressing both comments. Thanks for the review @Pearl1594 and @sureshanaparti.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org