You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by whhe <gi...@git.apache.org> on 2018/07/03 03:28:35 UTC

[GitHub] incubator-griffin issue #332: fix a bad practice

Github user whhe commented on the issue:

    https://github.com/apache/incubator-griffin/pull/332
  
    Hi @toyboxman 
    
    Thanks for your advice, but I think the line separator here has nothing to do with platform. Elasticsearch just use it (in http entity) to identify the bulk request body, see docs : https://www.elastic.co/guide/en/elasticsearch/reference/6.0/docs-bulk.html
    
    Besides, If we use %n here, maybe more code should be modified to keep consistency.
    https://github.com/apache/incubator-griffin/blob/37b5cbbe10c7e7c26176a4cfafdceba5ef17e3b1/service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java#L146


---