You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/10/16 09:13:00 UTC
[GitHub] [qpid-proton] jiridanek opened a new pull request #274: PROTON-2169 Require distutils to build Python binding
jiridanek opened a new pull request #274:
URL: https://github.com/apache/qpid-proton/pull/274
Without the module present, the build would fail with a
somewhat cryptic final error saying
```
CMake Error at python/CMakeLists.txt:139 (install):
install FILES given no DESTINATION!
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] RoddieKieley commented on pull request #274: PROTON-2169 Require distutils to build Python binding
Posted by GitBox <gi...@apache.org>.
RoddieKieley commented on pull request #274:
URL: https://github.com/apache/qpid-proton/pull/274#issuecomment-739003106
As a quick note here, the failure in the checks above was due to known issue [PROTON-2231](https://issues.apache.org/jira/browse/PROTON-2231) related to the c threaderciser. The failure should be unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #274: PROTON-2169 Require distutils to build Python binding
Posted by GitBox <gi...@apache.org>.
astitcher commented on pull request #274:
URL: https://github.com/apache/qpid-proton/pull/274#issuecomment-765454696
As far as I know distutils is in the Python standard library (although deprecated and replaced by setuptools) and so should be present for any correct python installation. We don't check that other standard libraries we rely on are present,
The actual issue might be using distutils at all! Especially in the Python CMake file. The setup.py already mostly uses setuptools and probably could stop using distutils completely with some amount of work!
So I'd say on balance this change isn't really needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-io commented on pull request #274: PROTON-2169 Require distutils to build Python binding
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #274:
URL: https://github.com/apache/qpid-proton/pull/274#issuecomment-709989354
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=h1) Report
> Merging [#274](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/9bcc7bb028422e3f1f345789e5a654f480e0b531?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 79.66% 79.65% -0.02%
==========================================
Files 342 342
Lines 42881 42888 +7
==========================================
- Hits 34163 34161 -2
- Misses 8718 8727 +9
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [ruby/spec/spec\_helper.rb](https://codecov.io/gh/apache/qpid-proton/pull/274/diff?src=pr&el=tree#diff-cnVieS9zcGVjL3NwZWNfaGVscGVyLnJi) | `62.26% <0.00%> (-1.89%)` | :arrow_down: |
| [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/274/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.09% <0.00%> (-0.35%)` | :arrow_down: |
| [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/274/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `81.62% <0.00%> (-0.11%)` | :arrow_down: |
| [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/274/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.73% <0.00%> (+0.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=footer). Last update [9bcc7bb...7110e30](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek closed pull request #274: PROTON-2169 Require distutils to build Python binding
Posted by GitBox <gi...@apache.org>.
jiridanek closed pull request #274:
URL: https://github.com/apache/qpid-proton/pull/274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on pull request #274: PROTON-2169 Require distutils to build Python binding
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #274:
URL: https://github.com/apache/qpid-proton/pull/274#issuecomment-739920203
> As a quick note here, the failure in the checks above was due to known issue [PROTON-2231](https://issues.apache.org/jira/browse/PROTON-2231) related to the c threaderciser. The failure should be unrelated to this PR.
The reason I got stuck on the PR is that it is actually quite difficult to install python (python-devel) without distutils. Its in fact impossible in ubuntu, due to package dependencies. It looks like doing that is extremely rare and maybe not worth checking for in CMake...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-io edited a comment on pull request #274: PROTON-2169 Require distutils to build Python binding
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #274:
URL: https://github.com/apache/qpid-proton/pull/274#issuecomment-709989354
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=h1) Report
> Merging [#274](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/9bcc7bb028422e3f1f345789e5a654f480e0b531?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 79.66% 79.65% -0.02%
==========================================
Files 342 342
Lines 42881 42888 +7
==========================================
- Hits 34163 34161 -2
- Misses 8718 8727 +9
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [ruby/spec/spec\_helper.rb](https://codecov.io/gh/apache/qpid-proton/pull/274/diff?src=pr&el=tree#diff-cnVieS9zcGVjL3NwZWNfaGVscGVyLnJi) | `62.26% <0.00%> (-1.89%)` | :arrow_down: |
| [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/274/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.09% <0.00%> (-0.35%)` | :arrow_down: |
| [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/274/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `81.62% <0.00%> (-0.11%)` | :arrow_down: |
| [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/274/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.73% <0.00%> (+0.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=footer). Last update [9bcc7bb...7110e30](https://codecov.io/gh/apache/qpid-proton/pull/274?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on pull request #274: PROTON-2169 Require distutils to build Python binding
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #274:
URL: https://github.com/apache/qpid-proton/pull/274#issuecomment-765457775
Ack; I'll close this (and the Jira) and will be more careful not to have broken python installs around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org