You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2016/06/13 17:59:29 UTC
Review Request 48658: Change from MultiFieldQueryParser to
StandardQueryParser
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48658/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
Removed tests specific to multi field query parsing
Currently using the first field as the default field. Future changes will allow user to pass in a default field.
Diffs
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 62cb65c
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java cfd8c32
Diff: https://reviews.apache.org/r/48658/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 48658: Change from MultiFieldQueryParser to
StandardQueryParser
Posted by Jason Huynh <hu...@gmail.com>.
> On June 13, 2016, 6:08 p.m., Dan Smith wrote:
> > I don't think we want to use the first field as the default field long term. That's behavior that might be confusing to users, especially since the order of the fields is not really defined if you pass in a map of fields->analyzers.
Yeah, I agree, it was more of a place holder until we figure out what our default field will be. I'll be working on adding api's to pass in the default field next and then we can figure out what the true default field should be...
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48658/#review137345
-----------------------------------------------------------
On June 13, 2016, 5:59 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48658/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 5:59 p.m.)
>
>
> Review request for geode, anilkumar gingade, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Removed tests specific to multi field query parsing
> Currently using the first field as the default field. Future changes will allow user to pass in a default field.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 62cb65c
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java cfd8c32
>
> Diff: https://reviews.apache.org/r/48658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 48658: Change from MultiFieldQueryParser to
StandardQueryParser
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48658/#review137345
-----------------------------------------------------------
Ship it!
I don't think we want to use the first field as the default field long term. That's behavior that might be confusing to users, especially since the order of the fields is not really defined if you pass in a map of fields->analyzers.
- Dan Smith
On June 13, 2016, 5:59 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48658/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 5:59 p.m.)
>
>
> Review request for geode, anilkumar gingade, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Removed tests specific to multi field query parsing
> Currently using the first field as the default field. Future changes will allow user to pass in a default field.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java 62cb65c
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java cfd8c32
>
> Diff: https://reviews.apache.org/r/48658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>