You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/02/14 20:20:48 UTC
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6003
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Almost all of the original Impala FAQ material was
Cloudera-themed or commercially oriented. Lots of
answers about the QuickStart VM, Cloudera discussion
forums, CDH-based recommendations, etc. IMO it is
not worth trying to adapt each FAQ entry to be generic.
Better to start over from the ground up.
Phase 1 of making an Apache-friendly FAQ is to strip
the original page "down to the studs" so new FAQ
entries can be added with more of a developer theme,
based on questions people have in the community.
Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
---
M docs/topics/impala_faq.xml
1 file changed, 8 insertions(+), 1,839 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/6003/1
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 1: Code-Review-1
> (2 comments)
>
> I made these changes but now when I push to gerrit I get:
>
> To ssh://max-webster@gerrit.cloudera.org:29418/Impala-ASF
> ! [remote rejected] HEAD -> refs/for/master (change
> http://gerrit.cloudera.org:8080/5802 closed)
> error: failed to push some refs to 'ssh://max-webster@gerrit.cloudera.org:29418/Impala-ASF'
>
> This after doing rebases against master and/or asf-gerrit where the
> list of commits was quite long. (This gerrit #5802 it's
> complaining about is "IMPALA-4829: Change default Kudu read
> behavior for "RYW"" which gerrit says is already merged.)
I haven't seen that before. Try to make a new branch by using one of the "Download" links in the upper-right-hand corner of this page.
I am -1ing to remind myself to come back and look at the "Done" item on line 46 when your new patch is pushed.
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/42/
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 2:
Somehow there was a conflicting change from a gerrit that I had abandoned that was getting in the way every time. Once I rebased against asf-gerrit/master and deleted that commit:
d 367a690 IMPALA-3406: [DOCS] Remove stale and Cloudera-specific URLs
I was able to push the new patch set.
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/44/
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Almost all of the original Impala FAQ material was
Cloudera-themed or commercially oriented. Lots of
answers about the QuickStart VM, Cloudera discussion
forums, CDH-based recommendations, etc. IMO it is
not worth trying to adapt each FAQ entry to be generic.
Better to start over from the ground up.
Phase 1 of making an Apache-friendly FAQ is to strip
the original page "down to the studs" so new FAQ
entries can be added with more of a developer theme,
based on questions people have in the community.
Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Reviewed-on: http://gerrit.cloudera.org:8080/6003
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_faq.xml
1 file changed, 6 insertions(+), 1,852 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Jim Apple: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6003/1//COMMIT_MSG
Commit Message:
Line 16: Phase 1 of making an Apache-friendly FAQ is to strip
I am OK with this.
http://gerrit.cloudera.org:8080/#/c/6003/1/docs/topics/impala_faq.xml
File docs/topics/impala_faq.xml:
PS1, Line 44: It will contain questions and answers
: of interest to the Apache Impala developer community, rather than FAQs
: for Impala end users.
I think this should be omitted for now. Why hamstring ourselves?
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 1:
(2 comments)
I made these changes but now when I push to gerrit I get:
To ssh://max-webster@gerrit.cloudera.org:29418/Impala-ASF
! [remote rejected] HEAD -> refs/for/master (change http://gerrit.cloudera.org:8080/5802 closed)
error: failed to push some refs to 'ssh://max-webster@gerrit.cloudera.org:29418/Impala-ASF'
This after doing rebases against master and/or asf-gerrit where the list of commits was quite long. (This gerrit #5802 it's complaining about is "IMPALA-4829: Change default Kudu read behavior for "RYW"" which gerrit says is already merged.)
http://gerrit.cloudera.org:8080/#/c/6003/1/docs/topics/impala_faq.xml
File docs/topics/impala_faq.xml:
Line 235
> Can you file a JIRA against Apache Impala (with component Docs) to add back
Done. https://issues.cloudera.org/browse/IMPALA-4947
PS1, Line 44: It will contain questions and answers
: of interest to the Apache Impala developer community, rather than FAQs
: for Impala end users.
> I think this should be omitted for now. Why hamstring ourselves?
Done
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6003
to look at the new patch set (#2).
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Almost all of the original Impala FAQ material was
Cloudera-themed or commercially oriented. Lots of
answers about the QuickStart VM, Cloudera discussion
forums, CDH-based recommendations, etc. IMO it is
not worth trying to adapt each FAQ entry to be generic.
Better to start over from the ground up.
Phase 1 of making an Apache-friendly FAQ is to strip
the original page "down to the studs" so new FAQ
entries can be added with more of a developer theme,
based on questions people have in the community.
Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
---
M docs/topics/impala_faq.xml
1 file changed, 6 insertions(+), 1,852 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/6003/2
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6003/1/docs/topics/impala_faq.xml
File docs/topics/impala_faq.xml:
Line 235
Can you file a JIRA against Apache Impala (with component Docs) to add back these FAQs that are still of use?
--
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes