You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/25 17:27:25 UTC

[GitHub] [trafficcontrol] zrhoffman opened a new issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

zrhoffman opened a new issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  bug report
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  [Ansible-based Lab Creation](https://github.com/apache/trafficcontrol/blob/1cd5046467/docs/source/admin/ansible-labs/ansible_labs.rst#ansible-based-lab-creation)
   
   ## Current behavior:
   <!-- Describe how the bug manifests -->
   The Ansible dataset loader uses `POST /divisions/{name}/regions` to create regions:
   https://github.com/apache/trafficcontrol/blob/1cd50464676b35dedcb41788ab99793972d85449/infrastructure/ansible/roles/dataset_loader/tasks/dataset_loader.yml#L372-L384
   
   Because that was a Perl-only endpoint, it has been gone since #5209 removed Traffic Ops Perl,
   
   ## Expected behavior:
   <!-- Describe what the behavior would be without the bug -->
   The Ansible dataset loader should use `POST /regions` to create Regions.
   
   ## Minimal reproduction of the problem with instructions:
   <!--
   If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
   include the applicable TC version.
   -->
   1. Run dataset loader
   2. See it fail due to
       ```json
       {
           "alerts": [
               {
                   "level": "error", 
                   "text": "The requested path '/api/1.3/divisions/Eastern/regions' does not exist."
               }
           ]
       }
       ```
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580#issuecomment-786173126


   It isn't separate. The two are intended for the same release. The API v1 removal is currently just waiting on the few places like this still using APIv1 - atm it's really just ORT, I think. Unless the dataset loader will also explode when that happens?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580#issuecomment-786253713


   > Then I'll open an issue for that as well.
   
   An issue (#5377) already exists to update the Ansible playbooks past API v1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 closed issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

Posted by GitBox <gi...@apache.org>.
ocket8888 closed issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a commented on issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580#issuecomment-786149962


   This isn't a problem with the dataset loader.  It's a problem that the backward compatibility promise of the TO API is broken.  This is a problem any consumer of the API might have.  The plan to remove 1.x should not have been separate from the perlectomy if this dependency isn't going to be fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] serDrem commented on issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

Posted by GitBox <gi...@apache.org>.
serDrem commented on issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580#issuecomment-786319076


   I will take care of this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580#issuecomment-786255460


   Oh, my bad.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580#issuecomment-786248080


   Then I'll open an issue for that as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] jhg03a commented on issue #5580: Ansible dataset loader uses removed, Perl-only endpoint POST /divisions/{name}/regions

Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #5580:
URL: https://github.com/apache/trafficcontrol/issues/5580#issuecomment-786199809


   Yes, it will.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org