You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by chipitsine <gi...@git.apache.org> on 2017/09/20 17:13:53 UTC

[GitHub] incubator-guacamole-server pull request #108: resolve issues identified by c...

GitHub user chipitsine opened a pull request:

    https://github.com/apache/incubator-guacamole-server/pull/108

    resolve issues identified by cppcheck

    [src/guacd/conf-file.c:206]: (error) Memory leak: conf
    [src/protocols/rdp/rdp_cliprdr.c:205]: (error) Memory leak: output
    [src/terminal/display.c:283]: (error) Memory leak: display
    [src/terminal/display.c:290]: (error) Memory leak: display

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chipitsine/incubator-guacamole-server master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-server/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit e0cc06e6fce1585889b71ee1a7072b5affe15837
Author: Ilya Shipitsin <ch...@gmail.com>
Date:   2017-09-20T17:11:10Z

    resolve issues identified by cppcheck
    
    [src/guacd/conf-file.c:206]: (error) Memory leak: conf
    [src/protocols/rdp/rdp_cliprdr.c:205]: (error) Memory leak: output
    [src/terminal/display.c:283]: (error) Memory leak: display
    [src/terminal/display.c:290]: (error) Memory leak: display

----


---

[GitHub] incubator-guacamole-server pull request #108: resolve issues identified by c...

Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-server/pull/108#discussion_r140036341
  
    --- Diff: src/guacd/conf-file.c ---
    @@ -203,6 +203,7 @@ guacd_config* guacd_conf_load() {
         /* Notify of errors preventing reading */
         else if (errno != ENOENT) {
             fprintf(stderr, "Unable to open \"" GUACD_CONF_FILE "\": %s\n", strerror(errno));
    +	free(conf);
    --- End diff --
    
    Please check your style - this indentation should match the indentation around it.  See the following document:
    http://guacamole.incubator.apache.org/guac-style/


---

[GitHub] incubator-guacamole-server pull request #108: GUACAMOLE-383: resolve issues ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-server/pull/108


---