You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/19 13:56:00 UTC
[jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible
with Dart 2
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656836#comment-16656836 ]
ASF GitHub Bot commented on THRIFT-4654:
----------------------------------------
robbecker-wf opened a new pull request #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility (backwards compatible)
URL: https://github.com/apache/thrift/pull/1617
# Overview
Make the minimal changes needed to make the dart code compatible with Dart 2 while being backwards compatible with Dart 1. This fixes https://issues.apache.org/jira/browse/THRIFT-4654
# Changes
- Specify the Dart SDK range in the pubspec.yaml file to allow Dart 1 & 2. NOTE: This does up the minimum from 1.13.0 to 1.24.3 but I don't believe anyone is using that old of a Dart.
- Use the dart2_constant package to adjust constant usage from all caps constant names to camel case constant names.
# Testing
- [ ] Install dependencies under Dart 1 and Dart 2 by running `pub get`
- [ ] Verify the tests pass by running `pub run test` under Dart 1 and 2 (I did this locally)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Thrift Dart port is not compatible with Dart 2
> ----------------------------------------------
>
> Key: THRIFT-4654
> URL: https://issues.apache.org/jira/browse/THRIFT-4654
> Project: Thrift
> Issue Type: Improvement
> Components: Dart - Library
> Environment: Any OS, under Dart 2+
> Reporter: Rob Becker
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires opting in via a setting in the pubspec.yaml and the code needs to update the use of all caps constant names to the new camel case names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)