You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/11/25 17:54:04 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new issue #6382: Geo Limit Countries should be an array
ocket8888 opened a new issue #6382:
URL: https://github.com/apache/trafficcontrol/issues/6382
## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:
- Traffic Ops
## Current behavior:
Currently, it's a string that represents an array of strings separated by commas e.g. `"US,CA"`.
## New behavior:
Arrays should be arrays e.g. `["US", "CA"]`. If the parser is smart enough (and if we care to do it this way), that could be done in a backward-compatible manner such that if the field is a string it's parsed as a comma-delimited array, and if it's an array it's parsed as such. With the right validation (currently it has none, but country codes can't, for example, legally contain commas) the storage format could even be kept the same, which not only obviates the need for a migration but trivializes supporting old API versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 commented on issue #6382: Geo Limit Countries should be an array
Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on issue #6382:
URL: https://github.com/apache/trafficcontrol/issues/6382#issuecomment-997069334
@ocket8888 I can take this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 closed issue #6382: Geo Limit Countries should be an array
Posted by GitBox <gi...@apache.org>.
ocket8888 closed issue #6382:
URL: https://github.com/apache/trafficcontrol/issues/6382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 closed issue #6382: Geo Limit Countries should be an array
Posted by GitBox <gi...@apache.org>.
ocket8888 closed issue #6382:
URL: https://github.com/apache/trafficcontrol/issues/6382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org