[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192
URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r194661744
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -186,4 +186,14 @@ whisk {
         constraint-delimiter = " "//used to parse constraint strings
         teardown-on-exit = true //set to true to disable the mesos framework on system exit; set for false for HA deployments
     }
+
+    # tracing configuration
+    tracing {
+        cache-expiry = 30 #cache expiry in seconds. Set to appropriate value to trace long running requests
+        #zipnkin configuration. Uncomment following to enable zipkin based tracing
+        #zipkin {
+        #    url = "http://localhost:9411" //url to connecto to zipkin server
+        #    sample-rate = "0.01"
 
 Review comment:
   Can we link to some document which explains the `sample-rate` for reference. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services