[GitHub] [incubator-tvm] moderato commented on pull request #5811: [AutoTVM] Support using IterVar directly in define_reorder with 'candidate' policy.

[GitBox <gi...@apache.org>]

moderato commented on pull request #5811:
URL: https://github.com/apache/incubator-tvm/pull/5811#issuecomment-645699015


   > Because the `name` is only used for printing and debugging, it does not matter.
   > The correct way is that you create VirtualAxis in your templates explicitly and do not rely on `name` to do the equality check.
   > 
   > If you agree with this, we can close the PR. The existing code does not have bugs.
   
   Well, the `name_ct` variable does affect the equality check at places like
   https://github.com/apache/incubator-tvm/blob/052ea4d14d4a528ae7a2c1f39e74436284864d39/python/tvm/autotvm/task/space.py#L313
   when `var` is an `IterVar` and needed to be converted to `VirtualAxis`. That's why I was asking about `name`. Or, would you suggest to change the equality check codes?
   
   However, if the plan to support `IterVar` is to be done in the future instead of now, I agree we can close this PR for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org