You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/16 08:21:15 UTC

[GitHub] [flink] aljoscha opened a new pull request #13658: [FLINK-19671] Update EditorConfig file to be useful

aljoscha opened a new pull request #13658:
URL: https://github.com/apache/flink/pull/13658


   We should update our .editorconfig file to format Java code according to a style that passes our checkstyle rules and also applies our import ordering. This will greatly simplify development because developers can just "re-format code" in IntelliJ and be done with it.
   
   Please look at the two commit messages to see what's going on.
   
   See the ML discussion for more background: https://lists.apache.org/thread.html/r481bb622410718cd454d251b194c7c1ad358e5d861fdacc9a4be3b5b%40%3Cdev.flink.apache.org%3E


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #13658: [FLINK-19671] Update EditorConfig file to be useful

Posted by GitBox <gi...@apache.org>.

aljoscha closed pull request #13658:
URL: https://github.com/apache/flink/pull/13658


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13658: [FLINK-19671] Update EditorConfig file to be useful

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13658:
URL: https://github.com/apache/flink/pull/13658#issuecomment-709903565

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 4fbff68d2bcdea44988eb50c1866d7005336bdbc (Fri Oct 16 08:24:21 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13658: [FLINK-19671] Update EditorConfig file to be useful

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13658:
URL: https://github.com/apache/flink/pull/13658#issuecomment-709910502


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4fbff68d2bcdea44988eb50c1866d7005336bdbc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4fbff68d2bcdea44988eb50c1866d7005336bdbc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4fbff68d2bcdea44988eb50c1866d7005336bdbc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #13658: [FLINK-19671] Update EditorConfig file to be useful

Posted by GitBox <gi...@apache.org>.

aljoscha commented on pull request #13658:
URL: https://github.com/apache/flink/pull/13658#issuecomment-709911648


   Thanks, I merged!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org