You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/05 08:36:34 UTC

[GitHub] [kafka] chia7712 opened a new pull request #10632: MINOR: fix streams_broker_compatibility_test.py

chia7712 opened a new pull request #10632:
URL: https://github.com/apache/kafka/pull/10632


   related to #10573 
   
   the log message was changed and so the system test can't capture expected message.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #10632: MINOR: fix streams_broker_compatibility_test.py

Posted by GitBox <gi...@apache.org>.

ableegoldman commented on pull request #10632:
URL: https://github.com/apache/kafka/pull/10632#issuecomment-832901885


   @chia7712 I'm just going to go ahead and merge this so we can get the system tests fixed ASAP. Hope you don't mind, and thank you again for the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman merged pull request #10632: MINOR: fix streams_broker_compatibility_test.py

Posted by GitBox <gi...@apache.org>.

ableegoldman merged pull request #10632:
URL: https://github.com/apache/kafka/pull/10632


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10632: MINOR: fix streams_broker_compatibility_test.py

Posted by GitBox <gi...@apache.org>.

chia7712 commented on pull request #10632:
URL: https://github.com/apache/kafka/pull/10632#issuecomment-832516822


   ```
   jdk_version="openjdk:8" \
   TC_PATHS="tests/kafkatest/tests/streams/streams_broker_compatibility_test.py::StreamsBrokerCompatibility.test_fail_fast_on_incompatible_brokers_if_eos_beta_enabled" \
   /bin/bash tests/docker/run_tests.sh
   ```
   
   all pass
   
   <img width="1357" alt="截圖 2021-05-05 下午4 36 41" src="https://user-images.githubusercontent.com/6234750/117115800-2e79ea80-adc0-11eb-864c-2248dc355cdc.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10632: MINOR: fix streams_broker_compatibility_test.py

Posted by GitBox <gi...@apache.org>.

chia7712 commented on pull request #10632:
URL: https://github.com/apache/kafka/pull/10632#issuecomment-832903232


   >  I'm just going to go ahead and merge this so we can get the system tests fixed ASAP. Hope you don't mind
   
   thanks for merging this patch :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org