You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/21 01:49:23 UTC
[GitHub] [skywalking] easonyipj opened a new pull request, #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
easonyipj opened a new pull request, #9823:
URL: https://github.com/apache/skywalking/pull/9823
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
### <Feature description>
Add Golang runtime metrics and cpu/memory used rate panels in FaaS-Instance dashboard, the more detail about the Golang metrics can be seen in [(Summer 2022)Feat add golang runtime metrics #9711](https://github.com/apache/skywalking/pull/9711).
<img width="1312" alt="image" src="https://user-images.githubusercontent.com/34618178/197092143-bcd429ea-2c0f-4963-8c33-1e394ec9ea6a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286375819
:warning: **6 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/skywalking/01GFW3P2V2ZXYEBERS89F9XE5B?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20skywalking) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286360102
Sorry, my fault. Yes, they are in the general dashboard already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9823:
URL: https://github.com/apache/skywalking/pull/9823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] easonyipj commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
easonyipj commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286454015
Sorry, I made a wrong operation for requesting review from [wu-sheng](https://github.com/wu-sheng) and removed request for [arugal](https://github.com/arugal)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] easonyipj commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
easonyipj commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286454228
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] easonyipj commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
easonyipj commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286462773
> My appoval is still there I think. We are just blocked by CI.
Yes, I got it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286354176
I think it should be in general service dashboard as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] easonyipj commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
easonyipj commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286361604
> Sorry, my fault. Yes, they are in the general dashboard already.
That's all right, thanks for helping me check the things again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286461512
My appoval is still there I think. We are just blocked by CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] easonyipj commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
easonyipj commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286358181
> I think it should be in general service dashboard as well?
Yes, the Golang metrics panels has been put in General-Instance dashboard at all, we can enter the General-Instance dashboard at all from General-Service borad's instance tap, so the work you have mentioned is just done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286453920
I think I had appoved, what changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] easonyipj closed pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
easonyipj closed pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
URL: https://github.com/apache/skywalking/pull/9823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] easonyipj commented on pull request #9823: [feat]Add Golang metrics panels in FaaS-Instance dashboard
Posted by GitBox <gi...@apache.org>.
easonyipj commented on PR #9823:
URL: https://github.com/apache/skywalking/pull/9823#issuecomment-1286455994
> Sorry, I made a wrong operation for requesting review from [wu-sheng](https://github.com/wu-sheng) and removed request for [arugal](https://github.com/arugal)
@wu-sheng @arugal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org