You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Jibing-Li (via GitHub)" <gi...@apache.org> on 2023/06/14 08:23:50 UTC
[GitHub] [doris] Jibing-Li opened a new pull request, #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.
Jibing-Li opened a new pull request, #20799:
URL: https://github.com/apache/doris/pull/20799
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
Nereids planner only support JDBC external catalog, this pr is to support JDBC external table for nereids.
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20799:
URL: https://github.com/apache/doris/pull/20799#issuecomment-1590988790
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20799:
URL: https://github.com/apache/doris/pull/20799#issuecomment-1590988715
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #20799:
URL: https://github.com/apache/doris/pull/20799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #20799:
URL: https://github.com/apache/doris/pull/20799#discussion_r1229437034
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJdbcScan.java:
##########
@@ -31,28 +33,28 @@
import java.util.Optional;
/**
- * Logical scan for external jdbc catalog.
+ * Logical scan for external jdbc catalog and jdbc table.
*/
public class LogicalJdbcScan extends LogicalRelation {
/**
* Constructor for LogicalJdbcScan.
*/
- public LogicalJdbcScan(ObjectId id, ExternalTable table, List<String> qualifier,
+ public LogicalJdbcScan(ObjectId id, TableIf table, List<String> qualifier,
Optional<GroupExpression> groupExpression,
Optional<LogicalProperties> logicalProperties) {
super(id, PlanType.LOGICAL_JDBC_SCAN, table, qualifier,
groupExpression, logicalProperties);
}
- public LogicalJdbcScan(ObjectId id, ExternalTable table, List<String> qualifier) {
+ public LogicalJdbcScan(ObjectId id, TableIf table, List<String> qualifier) {
this(id, table, qualifier, Optional.empty(), Optional.empty());
}
@Override
- public ExternalTable getTable() {
- Preconditions.checkArgument(table instanceof ExternalTable);
- return (ExternalTable) table;
+ public TableIf getTable() {
+ Preconditions.checkArgument(table instanceof ExternalTable || table instanceof JdbcTable);
Review Comment:
please add check error msg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20799:
URL: https://github.com/apache/doris/pull/20799#issuecomment-1590987397
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20799:
URL: https://github.com/apache/doris/pull/20799#issuecomment-1591057600
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Jibing-Li commented on pull request #20799: [Improvement](jdbc external table)Support jdbc external table for nereids.
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #20799:
URL: https://github.com/apache/doris/pull/20799#issuecomment-1591055154
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org