You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2016/10/11 15:51:04 UTC
[GitHub] brooklyn-server pull request #378: Add more sensors for main.uri, based on t...
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/378
Add more sensors for main.uri, based on the context, i.e public or not
Create 2 new sensors: `main.uri.mapped.public` and `main.uri.mapped.subnet`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-server fix/main-uri
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #378
----
commit ed6a8f580a7d6bf55cff37f9dc4ac858e091b310
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2016-10-11T15:49:39Z
Add more sensors for main.uri, based on the context, i.e public or not
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #378: Add more sensors for main.uri, based on the cont...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/378
Changes look good, and low risk to me! Eye-baling the code, I don't see how they could cause any problems or build failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #378: Add more sensors for main.uri, based on the cont...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/378
I've checked this branch out locally, to check it. Merging now (as jenkins builds is not managing to even try to build this).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #378: Add more sensors for main.uri, based on the cont...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/378
@aledsage Force pushed, Jenkins is still complaining with the same error message. Something wrong on Apache Infra?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #378: Add more sensors for main.uri, based on t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/378
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #378: Add more sensors for main.uri, based on the cont...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/378
Build failed with:
```
GitHub pull request #378 to apache/brooklyn-server
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-eu2 (Ubuntu ubuntu ubuntu-eu docker) in workspace /home/jenkins/jenkins-slave/workspace/brooklyn-server-pull-requests
java.io.IOException: Failed to mkdirs: /home/jenkins/jenkins-slave/workspace/brooklyn-server-pull-requests
```
@tbouron can you kick this off again (e.g. by doing something like `git commit --amend && git push --force branch`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---