You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/10 07:20:56 UTC

[GitHub] [incubator-echarts-doc] joyhchen opened a new pull request #124: fix(documentation): Fix typos in English documentation

joyhchen opened a new pull request #124:
URL: https://github.com/apache/incubator-echarts-doc/pull/124


   This mostly fixes typos, but there are also some minor grammatical changes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts-doc] susiwen8 commented on pull request #124: fix(documentation): Fix typos in English documentation

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #124:
URL: https://github.com/apache/incubator-echarts-doc/pull/124#issuecomment-656527645


   Thank you very much!!!!!!!!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull request #124: fix(documentation): Fix typos in English documentation

Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #124:
URL: https://github.com/apache/incubator-echarts-doc/pull/124#discussion_r453199550



##########
File path: en/option/series/map.md
##########
@@ -5,7 +5,7 @@
 
 **Map.**
 
-Map is maily used in the visulization of geographic area data, which can be used with [visualMap](~visualMap) component to visualize the datas such as population distribution density in diffrent areas.
+Map is maimly used in the visualization of geographic area data, which can be used with [visualMap](~visualMap) component to visualize the datas such as population distribution density in diffrent areas.

Review comment:
       Oh. This is a typo I didn't notice. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts-doc] plainheart commented on a change in pull request #124: fix(documentation): Fix typos in English documentation

Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #124:
URL: https://github.com/apache/incubator-echarts-doc/pull/124#discussion_r452914929



##########
File path: en/option/series/map.md
##########
@@ -5,7 +5,7 @@
 
 **Map.**
 
-Map is maily used in the visulization of geographic area data, which can be used with [visualMap](~visualMap) component to visualize the datas such as population distribution density in diffrent areas.
+Map is maimly used in the visualization of geographic area data, which can be used with [visualMap](~visualMap) component to visualize the datas such as population distribution density in diffrent areas.

Review comment:
       > Map is maimly used in the visualization
   
   maimly  -> mainly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts-doc] pissang merged pull request #124: fix(documentation): Fix typos in English documentation

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #124:
URL: https://github.com/apache/incubator-echarts-doc/pull/124


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts-doc] plainheart commented on pull request #124: fix(documentation): Fix typos in English documentation

Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #124:
URL: https://github.com/apache/incubator-echarts-doc/pull/124#issuecomment-657071346


   That's OK. This PR can be merged but need to correct a typo about 'maimly'. The others I mentioned may be finished in other PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts-doc] pissang commented on pull request #124: fix(documentation): Fix typos in English documentation

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #124:
URL: https://github.com/apache/incubator-echarts-doc/pull/124#issuecomment-657359554


   Merged, @joyhchen thanks for the wonderful job!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts-doc] plainheart commented on a change in pull request #124: fix(documentation): Fix typos in English documentation

Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #124:
URL: https://github.com/apache/incubator-echarts-doc/pull/124#discussion_r452913892



##########
File path: en/option/component/visual-map-piecewise.md
##########
@@ -215,7 +215,7 @@ When they are not specified, `itemSymbol` is adopted as the default value (but j
 
 the formatter tool for label.
 
-+ If it was set as a `string`, it refers to a template, for instance: `aaaa{value}bbbb{value2}`, where `{value}` and `{value2}` represents the current seleted range of dataValues.
++ If it was set as a `string`, it refers to a template, for instance: `aaaa{value}bbbb{value2}`, where `{value}` and `{value2}` represents the current selected range of dataValues.

Review comment:
       > If it was set as a `string`, it refers to a template,
   
   No need to use `was`, use `is` instead.

##########
File path: en/option/series/custom.md
##########
@@ -6,7 +6,7 @@
 
 `custom series` supports customizing graphic elements, and then generate more types of charts.
 
-echarts manages the creation, deletion, animation and interaction with other components (like [dataZoom](~dataZoom)、[visualMap](~visualMap)), which frees developers from handle those issue themselves.
+echarts manages the creation, deletion, animation and interaction with other components (like [dataZoom](~dataZoom)、[visualMap](~visualMap)), which frees developers from handling those issue themselves.

Review comment:
       > echarts manages the creation, deletion, animation and...
   
   It's better to use `ECharts` instead of `echarts` and same in the Chinese documentation.

##########
File path: en/option/series/map.md
##########
@@ -27,7 +27,7 @@ Series of same [map type](~series-map.map) will show in one map. At this point,
 
 In default case, map series create exclusive `geo` component for themselves. But `geoIndex` can be used to specify an outer [geo component](~geo), which can be shared with other series like [pie](~series-pie). Moreover, the region color of the outer [geo component](~geo) can be controlled by the map series (via [visualMap](~visualMap)).
 
-When `geoIndex` specified, [series-map.map](~series-map.map) other style configurations like [series-map.itemStyle](~series-map.itemStyle) will not work, but cooresponding configurations in [geo component](~geo) will be used.
+When `geoIndex` specified, [series-map.map](~series-map.map) other style configurations like [series-map.itemStyle](~series-map.itemStyle) will not work, but corresponding configurations in [geo component](~geo) will be used.

Review comment:
       My opinion about this paragraph is as follows.
   1) using **When `geoIndex` is specified** is better.
   2) `and` should be inserted before **other style configurations**

##########
File path: en/option/series/map.md
##########
@@ -5,7 +5,7 @@
 
 **Map.**
 
-Map is maily used in the visulization of geographic area data, which can be used with [visualMap](~visualMap) component to visualize the datas such as population distribution density in diffrent areas.
+Map is maimly used in the visualization of geographic area data, which can be used with [visualMap](~visualMap) component to visualize the datas such as population distribution density in diffrent areas.

Review comment:
       > Map is maimly used in the visualization
   
   mainly  -> mainly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org