You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/07/11 13:16:06 UTC
[kudu-CR] Autogenerate the release index.md file
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13844
Change subject: Autogenerate the release index.md file
......................................................................
Autogenerate the release index.md file
When building the docs for a release, this patch
also builds the index.md file.
Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
---
A docs/support/scripts/index_template.md
M docs/support/scripts/make_site.sh
2 files changed, 59 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/13844/1
--
To view, visit http://gerrit.cloudera.org:8080/13844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
Gerrit-Change-Number: 13844
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Autogenerate the release index.md file
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13844
to look at the new patch set (#2).
Change subject: Autogenerate the release index.md file
......................................................................
Autogenerate the release index.md file
When building the docs for a release, this patch
also builds the index.md file.
Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
---
A docs/support/scripts/index_template.md
M docs/support/scripts/make_site.sh
2 files changed, 59 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/13844/2
--
To view, visit http://gerrit.cloudera.org:8080/13844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
Gerrit-Change-Number: 13844
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Autogenerate the release index.md file
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 )
Change subject: Autogenerate the release index.md file
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh
File docs/support/scripts/make_site.sh:
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh@a164
PS1, Line 164:
:
:
:
:
:
:
> First I thought that was something related to this particular change, but t
This was just dead code, yes as a result of 819a85fbb.
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh@165
PS1, Line 165: {KUDU_VERSION}
> Is there a particular reason to use this sort of substitution pattern inste
No particular reason, I can switch.
--
To view, visit http://gerrit.cloudera.org:8080/13844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
Gerrit-Change-Number: 13844
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:58:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] Autogenerate the release index.md file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 )
Change subject: Autogenerate the release index.md file
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
Gerrit-Change-Number: 13844
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Jul 2019 19:09:29 +0000
Gerrit-HasComments: No
[kudu-CR] Autogenerate the release index.md file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 )
Change subject: Autogenerate the release index.md file
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh
File docs/support/scripts/make_site.sh:
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh@a164
PS1, Line 164:
:
:
:
:
:
:
> This was just dead code, yes as a result of 819a85fbb.
Thanks for confirming!
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh@165
PS1, Line 165: {KUDU_VERSION}
> No particular reason, I can switch.
I see. Yep, it would be nice to use the same pattern :)
--
To view, visit http://gerrit.cloudera.org:8080/13844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
Gerrit-Change-Number: 13844
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Jul 2019 19:01:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] Autogenerate the release index.md file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13844 )
Change subject: Autogenerate the release index.md file
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh
File docs/support/scripts/make_site.sh:
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh@a164
PS1, Line 164:
:
:
:
:
:
:
First I thought that was something related to this particular change, but then I realized that the removal of these lines is just a follow-up to 819a85fbb, right?
http://gerrit.cloudera.org:8080/#/c/13844/1/docs/support/scripts/make_site.sh@165
PS1, Line 165: {KUDU_VERSION}
Is there a particular reason to use this sort of substitution pattern instead of @@KUDU_VERSION@@ ? It seems the latter is already in use in other parts of the docs-making (e.g. see support/scripts/make_docs.sh for @@CONFIGURATION_REFERENCE@@ and @@TOOLS_REFERENCE@@ patterns)
--
To view, visit http://gerrit.cloudera.org:8080/13844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
Gerrit-Change-Number: 13844
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:57:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] Autogenerate the release index.md file
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13844 )
Change subject: Autogenerate the release index.md file
......................................................................
Autogenerate the release index.md file
When building the docs for a release, this patch
also builds the index.md file.
Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
Reviewed-on: http://gerrit.cloudera.org:8080/13844
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
A docs/support/scripts/index_template.md
M docs/support/scripts/make_site.sh
2 files changed, 59 insertions(+), 7 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If93fe00aa0dd855d8f8fafa22c786747d2ae50ed
Gerrit-Change-Number: 13844
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)