[jira] [Commented] (ARTEMIS-2214) ARTEMIS-2214 Cache durable&deliveryTime in PagedReference

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733922#comment-16733922 ] 

ASF GitHub Bot commented on ARTEMIS-2214:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2482#discussion_r245233815
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java ---
    @@ -120,14 +126,16 @@ public PagedReferenceImpl(final PagePosition position,
              this.largeMessage = message.getMessage().isLargeMessage() ? IS_LARGE_MESSAGE : IS_NOT_LARGE_MESSAGE;
              this.transactionID = message.getTransactionID();
              this.messageID = message.getMessage().getMessageID();
    -
    +         this.durable = message.getMessage().isDurable() ? IS_DURABLE : IS_NOT_DURABLE;
    +         this.deliveryTime = message.getMessage().getScheduledDeliveryTime();
              //pre-cache the message size so we don't have to reload the message later if it is GC'd
              getPersistentSize();
           } else {
              this.largeMessage = UNDEFINED_IS_LARGE_MESSAGE;
              this.transactionID = -2;
              this.messageID = -1;
              this.messageSize = -1;
    +         this.durable = UNDEFINED_IS_DURABLE;
    --- End diff --
    
    for completeness (its a nit) set deliveryTime to its undefined value here.


> ARTEMIS-2214 Cache durable&deliveryTime in PagedReference
> ---------------------------------------------------------
>
>                 Key: ARTEMIS-2214
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2214
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.6.3
>            Reporter: Qihong Xu
>            Priority: Major
>         Attachments: stacks.txt
>
>
> We recently performed a test on artemis broker and found a severe performance issue.
> When paged messages are being consumed, decrementMetrics in QueuePendingMessageMetrics will try to ‘getMessage’ to check whether they are durable or not. In this way queue will be locked for a long time because page may be GCed and need to be reload entirely. Other operations rely on queue will be blocked at this time, which cause a significant TPS drop. Detailed stacks are attached below.
> This also happens when consumer is closed and messages are pushed back to the queue, artemis will check priority on return if these messages are paged.
> To solve the issue, durable and priority need to be cached in PagedReference just like messageID, transactionID and so on. I have applied a patch to fix the issue. Any review is appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)