[jira] Commented: (TEXEN-13) Generator.parse fails, if the outputfile points to a directory, that does not exist.

["Will Glass-Husain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEXEN-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533753 ] 

Will Glass-Husain commented on TEXEN-13:
----------------------------------------

Thanks for contributing.  Nice idea.  Does "ant test" work?

By the way, please take a look at the code style guidelines on our wiki when you have a chance.  It's much easier to update the code if the patch follows them.  (4 spaces, not tabs, and the bodies of all if statements need matching braces on their own lines).  I'll fix the code this time.


> Generator.parse fails, if the outputfile points to a directory, that does not exist.
> ------------------------------------------------------------------------------------
>
>                 Key: TEXEN-13
>                 URL: https://issues.apache.org/jira/browse/TEXEN-13
>             Project: Texen
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Sebastian Zarnekow
>             Fix For: 1.1
>
>         Attachments: GeneratorNotReallyASingleton.patch
>
>
> The Texentask generates the outputdirectory, if it does not exist, but the Generator-Implementation lacks this feature for control templates like the following:
> # control.vm
> $generator.parse("myTemplate.vm", "subdirectory/myTemplate.out")
> So either allow subclasses of TexenTask to use another Generator (1), or change the implementation of getWriter to allow the Generator to create absent directories(2).
> (1)
> line 486:
> Generator generator = createGenerator();
> protected Generator createGenerator() {
>   return Generator.getInstance();
> }
> (2)
> public Writer getWriter(final String path, final String encoding) throws Exception {
>   final File f = new File(path).getParentFile();
>   if (!f.exists()) {
>     f.mkdirs();
>   }
>   ..
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org