You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by ankurdave <gi...@git.apache.org> on 2014/04/16 23:06:17 UTC

[GitHub] spark pull request: Rebuild routing table after Graph.reverse

GitHub user ankurdave opened a pull request:

    https://github.com/apache/spark/pull/431

    Rebuild routing table after Graph.reverse

    GraphImpl.reverse used to reverse edges in each partition of the edge RDD but preserve the routing table and replicated vertex view, since reversing should not affect partitioning.
    
    However, the old routing table would then have incorrect information for srcAttrOnly and dstAttrOnly. These RDDs should be switched.
    
    A simple fix is for Graph.reverse to rebuild the routing table and replicated vertex view.
    
    Thanks to Bogdan Ghidireac for reporting this issue on the mailing list.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ankurdave/spark fix-reverse-bug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #431
    
----
commit 75d63cbd8f471cbc8c783cedfb6afe9fab3c7189
Author: Ankur Dave <an...@gmail.com>
Date:   2014-04-16T20:28:23Z

    Rebuild routing table after Graph.reverse
    
    GraphImpl.reverse used to reverse edges in each partition of the edge
    RDD but preserve the routing table and replicated vertex view, since
    reversing should not affect partitioning.
    
    However, the old routing table would then have incorrect information for
    srcAttrOnly and dstAttrOnly. These RDDs should be switched.
    
    A simple fix is for Graph.reverse to rebuild the routing table and
    replicated vertex view.
    
    Thanks to Bogdan Ghidireac for reporting this issue on the mailing list.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Rebuild routing table after Graph.reverse

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/431#issuecomment-40655640
  
    Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Rebuild routing table after Graph.reverse

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/431#issuecomment-40652460
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Rebuild routing table after Graph.reverse

Posted by rxin <gi...@git.apache.org>.

Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/431#issuecomment-40667820
  
    lgtm merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Rebuild routing table after Graph.reverse

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/431#issuecomment-40652448
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Rebuild routing table after Graph.reverse

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/431


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Rebuild routing table after Graph.reverse

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/431#issuecomment-40655641
  
    All automated tests passed.
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14187/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---