You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Tyler Hobbs (JIRA)" <ji...@apache.org> on 2016/09/14 21:10:21 UTC
[jira] [Commented] (CASSANDRA-12605) Timestamp-order searching of
sstables does not handle non-frozen UDTs, frozen collections correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491462#comment-15491462 ]
Tyler Hobbs commented on CASSANDRA-12605:
-----------------------------------------
Patch and pending CI runs:
||branch||testall||dtest||
|[CASSANDRA-12605-3.0|https://github.com/thobbs/cassandra/tree/CASSANDRA-12605-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12605-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12605-3.0-dtest]|
|[CASSANDRA-12605-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-12605-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12605-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-12605-trunk-dtest]|
> Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen collections correctly
> ---------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-12605
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12605
> Project: Cassandra
> Issue Type: Bug
> Reporter: Tyler Hobbs
> Assignee: Tyler Hobbs
>
> {{SinglePartitionReadCommand.queryNeitherCountersNorCollections()}} is used to determine whether we can search sstables in timestamp order. We cannot use this optimization when there are multicell values (such as unfrozen collections or UDTs). However, this method only checks {{column.type.isCollection() || column.type.isCounter()}}. Instead, it should check {{column.type.isMulticell() || column.type.isCounter()}}.
> This has two implications:
> * We are using timestamp-order searching when querying non-frozen UDTs, which can lead to incorrect/stale results being returned.
> * We are not taking advantage of this optimization when querying frozen collections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)