You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/07/10 21:53:30 UTC
[Impala-ASF-CR] Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10906
Change subject: Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
......................................................................
Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
This reverts commit 54b3c607f027c445fc8d52acc4d3b1073e84aa77.
Change-Id: I50aa9eb9f9ed862e0a87aeb70b2646ce26f7abf9
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
D fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
D fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
D fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 6 insertions(+), 335 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/10906/1
--
To view, visit http://gerrit.cloudera.org:8080/10906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50aa9eb9f9ed862e0a87aeb70b2646ce26f7abf9
Gerrit-Change-Number: 10906
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10906 )
Change subject: Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
......................................................................
Patch Set 1: Verified+1 Code-Review+2
Clean revert
--
To view, visit http://gerrit.cloudera.org:8080/10906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50aa9eb9f9ed862e0a87aeb70b2646ce26f7abf9
Gerrit-Change-Number: 10906
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Jul 2018 22:02:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10906 )
Change subject: Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
......................................................................
Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
This reverts commit 54b3c607f027c445fc8d52acc4d3b1073e84aa77.
Change-Id: I50aa9eb9f9ed862e0a87aeb70b2646ce26f7abf9
Reviewed-on: http://gerrit.cloudera.org:8080/10906
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Bikramjeet Vig <bi...@cloudera.com>
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
D fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
D fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
D fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 6 insertions(+), 335 deletions(-)
Approvals:
Bikramjeet Vig: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I50aa9eb9f9ed862e0a87aeb70b2646ce26f7abf9
Gerrit-Change-Number: 10906
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10906 )
Change subject: Revert "IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER"
......................................................................
Patch Set 1:
> Patch Set 1:
>
> Reverting this to unblock the broken build in profile=2 because of API in HMS that is no longer available.
Clean revert.
--
To view, visit http://gerrit.cloudera.org:8080/10906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50aa9eb9f9ed862e0a87aeb70b2646ce26f7abf9
Gerrit-Change-Number: 10906
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Jul 2018 21:58:59 +0000
Gerrit-HasComments: No