You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/12/04 02:40:32 UTC
[kudu-CR] [test] fix HybridClockTest.TestWaitUntilAfter TestCase2
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14823
Change subject: [test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
......................................................................
[test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
In case of slow execution (e.g., a TSAN build) and very low estimated
clock error (e.g., 0 as in case of 'system_unsync' clock), calling
HybridClock::WaitUntilAfter() for a fresh past hybrid timestamp returns
Status::OK() instead of Status::TimedOut() regardless of deadline
because the supplied timestamp is seen clearly in the past.
This patch addresses the issue by moving the target timestamp further
into the future. Now it's 2 milliseconds in the future, but it was
2 microseconds in the future prior to this patch.
Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/14823/1
--
To view, visit http://gerrit.cloudera.org:8080/14823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
Gerrit-Change-Number: 14823
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [test] fix HybridClockTest.TestWaitUntilAfter TestCase2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14823 )
Change subject: [test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
......................................................................
[test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
In case of slow execution (e.g., a TSAN build) and very low estimated
clock error (e.g., 0 as in case of 'system_unsync' clock), calling
HybridClock::WaitUntilAfter() for a fresh past hybrid timestamp returns
Status::OK() instead of Status::TimedOut() regardless of deadline
because the supplied timestamp is seen clearly in the past.
This patch addresses the issue by moving the target timestamp further
into the future. Now it's 2 milliseconds in the future, but it was
2 microseconds in the future prior to this patch.
Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
Reviewed-on: http://gerrit.cloudera.org:8080/14823
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
Gerrit-Change-Number: 14823
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix HybridClockTest.TestWaitUntilAfter TestCase2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14823 )
Change subject: [test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
......................................................................
Patch Set 1: Verified+1
Unrelated test failure in DeleteTabletITest.TestLeaderElectionDuringDeleteTablet
--
To view, visit http://gerrit.cloudera.org:8080/14823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
Gerrit-Change-Number: 14823
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2019 03:59:25 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix HybridClockTest.TestWaitUntilAfter TestCase2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14823 )
Change subject: [test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14823/1//COMMIT_MSG
Commit Message:
PS1:
This is to address the test failure as seen in https://gerrit.cloudera.org/#/c/14379/
--
To view, visit http://gerrit.cloudera.org:8080/14823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
Gerrit-Change-Number: 14823
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2019 02:43:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] fix HybridClockTest.TestWaitUntilAfter TestCase2
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14823 )
Change subject: [test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
......................................................................
Patch Set 1: Code-Review+2
Thanks for the fix. You may be interested in KUDU-2550 too.
--
To view, visit http://gerrit.cloudera.org:8080/14823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
Gerrit-Change-Number: 14823
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2019 05:55:03 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix HybridClockTest.TestWaitUntilAfter TestCase2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
Gerrit-Change-Number: 14823
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix HybridClockTest.TestWaitUntilAfter TestCase2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14823 )
Change subject: [test] fix HybridClockTest.TestWaitUntilAfter_TestCase2
......................................................................
Patch Set 1:
> Thanks for the fix. You may be interested in KUDU-2550 too.
Yep, I'll take a closer look this week. Thank you for the review!
--
To view, visit http://gerrit.cloudera.org:8080/14823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34108359a04b5bd3f2a957faf6d2e9a6dc022eb1
Gerrit-Change-Number: 14823
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2019 05:56:39 +0000
Gerrit-HasComments: No