[GitHub] [superset] dpgaspar commented on a change in pull request #12663: feat: request ids on API related endpoints

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #12663:
URL: https://github.com/apache/superset/pull/12663#discussion_r562624772



##########
File path: superset/views/base_api.py
##########
@@ -452,15 +483,18 @@ def get_text_for_model(model: Model) -> str:
         # handle filters
         filters = self._get_related_filter(datamodel, column_name, args.get("filter"))
         # Make the query
-        count, values = datamodel.query(
+        _, rows = datamodel.query(

Review comment:
       It's possible, but note that passing the filters and the ids the intent is not to have logical AND's on this case, but logical OR's. The goal is to have a generic filterable dropdown list (with pagination) that always includes a certain set of ID's on its response. So we expect a superset ;) of the ID's passed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org