You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/16 09:06:45 UTC

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #104: Make sure index rule ID is set by

hanahmily commented on code in PR #104:
URL: https://github.com/apache/skywalking-banyandb/pull/104#discussion_r851606201


##########
banyand/metadata/schema/index.go:
##########
@@ -19,16 +19,19 @@ package schema
 
 import (
 	"context"
+	"hash/crc32"
 
 	"google.golang.org/protobuf/proto"
 
 	commonv1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/common/v1"
 	databasev1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/database/v1"
+	"github.com/pkg/errors"

Review Comment:
   forget to run `make pre-push`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org