[GitHub] [trafficserver] jrushford commented on a change in pull request #7787: Fixes an issue where next hop unit tests crash when run on macOS.

[GitBox <gi...@apache.org>]

jrushford commented on a change in pull request #7787:
URL: https://github.com/apache/trafficserver/pull/7787#discussion_r627087827



##########
File path: proxy/http/remap/unit-tests/nexthop_test_stubs.cc
##########
@@ -125,6 +125,14 @@ build_request(int64_t sm_id, HttpSM *sm, sockaddr_in *ip, const char *os_hostnam
   sm->t_state.txn_conf               = reinterpret_cast<OverridableHttpConfigParams *>(_my_txn_conf);
 }
 
+void
+GetConfigInteger(int *v, const char *n)
+{
+  if (strncmp(n, "proxy.config.http.parent_proxy.max_trans_retries", strlen(n)) == 0) {

Review comment:
       @ywkaras I think strncmp() is safer.  Why do you prefer strcmp()?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org