You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/03 04:05:51 UTC

[GitHub] bowenli86 opened a new pull request #7011: [FLINK-10768][Table & SQL] Move external catalog related code from TableEnvironment to CatalogManager

bowenli86 opened a new pull request #7011: [FLINK-10768][Table & SQL] Move external catalog related code from TableEnvironment to CatalogManager
URL: https://github.com/apache/flink/pull/7011
 
 
   ## What is the purpose of the change
   
   In the design of Flink-Hive integration and external catalog enhancements, we propose using `CatalogManager` to manage all external catalogs and related aspects for a clearer separation. Currently all external catalogs are managed by `TableEnvironment`, which makes TableEnvironment bloated.
   
   Also, as discussed with @twalthr , since we are moving away from Scala, all new feature code will be in Java.
   
   This PR moves all EXISTING external catalogs related code from `TableEnvironment` to `CatalogManager`, and it's the initial step for `CatalogManager`. It blocks `[[FLINK-10698]Create CatalogManager class manages all external catalogs and temporary meta objects](https://issues.apache.org/jira/browse/FLINK-10698)`
   
   This PR is a PURE REFACTOR, only moving APIs around, NO change on the behaviors and NO new feature is added. 
   
   ## Brief change log
   
     - added `CatalogManager` in Java
     - moved external catalog related code from `TableEnvironment` to `CatalogManager`
     - added unit tests in `CatalogManagerTest`
   
   ## Verifying this change
   
   - This change is already covered by existing tests, such as *TableEnvironmentTest*.
   - This change added tests and can be verified as follows:
     - Added unit tests in `CatalogManagerTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
   none
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services