You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/27 08:51:28 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #6039: [INLONG-6038][TubeMQ] Optimize FlowCtrlRuleHandler.updateFlowCtrlInfo()

healchow commented on code in PR #6039:
URL: https://github.com/apache/inlong/pull/6039#discussion_r980959567


##########
inlong-tubemq/tubemq-client/src/main/java/org/apache/inlong/tubemq/client/config/ConsumerConfig.java:
##########
@@ -245,7 +245,11 @@ public int getMaxSubInfoReportIntvlTimes() {
     }
 
     public void setMaxSubInfoReportIntvlTimes(int maxSubInfoReportIntvlTimes) {
-        this.maxSubInfoReportIntvlTimes = maxSubInfoReportIntvlTimes;
+        if (maxSubInfoReportIntvlTimes < 3) {
+            this.maxSubInfoReportIntvlTimes = 3;
+        } else {
+            this.maxSubInfoReportIntvlTimes = maxSubInfoReportIntvlTimes;
+        }

Review Comment:
   ```suggestion
           this.maxSubInfoReportIntvlTimes = Math.max(maxSubInfoReportIntvlTimes, 3);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org