You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by lindzh <gi...@git.apache.org> on 2017/04/24 11:45:29 UTC
[GitHub] incubator-rocketmq pull request #97: fix consumeTimestamp and wrong consumeT...
GitHub user lindzh opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/97
fix consumeTimestamp and wrong consumeTimestamp exception message
When I want to consume message,I use the following code,
```
consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET);
consumer.setConsumeTimestamp("2017_0422_235500");
```
and I got the tip,
```
Exception in thread "main" org.apache.rocketmq.client.exception.MQClientException: consumeTimestamp is invalid, YYYY_MMDD_HHMMSS
See http://rocketmq.apache.org/docs/faq/ for further details.
at org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.checkConfig(DefaultMQPushConsumerImpl.java:661)
```
The right answer is yyyyMMddHHmmss but the response is YYYY_MMDD_HHMMSS,I think the tip is misleading our judgments.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lindzh/incubator-rocketmq fix_consume_time
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 9acd59f89c730630d844c6f35c137ac60be7ac16
Author: dezhi.ldz <de...@alibaba-inc.com>
Date: 2017-04-24T11:35:36Z
fix consumeTimestamp and wrong consumeTimestamp exception message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #97: [ROCKETMQ-189] Misleading tip on consumeTimest...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
@lindzh This is PR is merged. you may close this PR now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #97: fix consumeTimestamp and wrong consumeTimestam...
Posted by vsair <gi...@git.apache.org>.
Github user vsair commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
Hi, Thanks for your contribution! But, could you please rename the title, like, [ROCKETMQ-XXX]?
Also, you should create an issue at https://issues.apache.org/jira/browse/ROCKETMQ/?selectedTab=com.atlassian.jira.jira-projects-plugin:issues-panel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #97: fix consumeTimestamp and wrong consumeTimestam...
Posted by lindzh <gi...@git.apache.org>.
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
Thanks for vsair's advice to get more familiar with the apache way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #97: [ROCKETMQ-189] Misleading tip on consumeTimest...
Posted by lindzh <gi...@git.apache.org>.
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
Providing a user-friendly feedback makes our component use more easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #97: fix consumeTimestamp and wrong consumeTimestam...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
[](https://coveralls.io/builds/11211354)
Coverage decreased (-0.1%) to 30.835% when pulling **1544413fba427b5610cc8672a9546c2f55ce141b on lindzh:fix_consume_time** into **fa85abcdf6ee46e56403ddf86828a38683103fd0 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #97: [ROCKETMQ-189] Misleading tip on consum...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #97: [ROCKETMQ-189] Misleading tip on consumeTimest...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
IMO,if we could polish here. we 'd better tell what's wrong with your input and what's a valid input ,right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---