You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/19 09:03:56 UTC

[GitHub] [flink] StephanEwen commented on issue #9681: [FLINK-13450][test] Adjust tests to tolerate arithmetic differences between x86 and ARM

StephanEwen commented on issue #9681: [FLINK-13450][test] Adjust tests to tolerate arithmetic differences between x86 and ARM
URL: https://github.com/apache/flink/pull/9681#issuecomment-533038922
 
 
   Could we reduce the changes to the scope where we really need strict results?
   It looks like this mainly matters for result verification (some tests) and for the SQL functions.
   
   In other parts, like exponential backoff, strict precision doesn't actually matter.
   In some parts, like samplers, the performance is more important than the precision, so we should not use StrictMath there at all.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services