[shardingsphere-elasticjob-lite] branch master updated: Add default value to fields in JobConfigurationPOJO (#1053)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob-lite.git


The following commit(s) were added to refs/heads/master by this push:
     new 3969c3d  Add default value to fields in JobConfigurationPOJO (#1053)
3969c3d is described below

commit 3969c3df21a0bab5848a057fe469f898d579167c
Author: 吴伟杰 <ro...@me.com>
AuthorDate: Tue Jul 14 10:19:25 2020 +0800

    Add default value to fields in JobConfigurationPOJO (#1053)
---
 .../elasticjob/lite/internal/config/pojo/JobConfigurationPOJO.java  | 2 +-
 .../lite/internal/config/pojo/JobConfigurationPOJOTest.java         | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/config/pojo/JobConfigurationPOJO.java b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/config/pojo/JobConfigurationPOJO.java
index 5ce79cf..f75c314 100644
--- a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/config/pojo/JobConfigurationPOJO.java
+++ b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/config/pojo/JobConfigurationPOJO.java
@@ -46,7 +46,7 @@ public final class JobConfigurationPOJO {
     
     private boolean misfire;
     
-    private int maxTimeDiffSeconds;
+    private int maxTimeDiffSeconds = -1;
     
     private int reconcileIntervalMinutes;
     
diff --git a/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/config/pojo/JobConfigurationPOJOTest.java b/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/config/pojo/JobConfigurationPOJOTest.java
index bf5d7b3..5b4328c 100644
--- a/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/config/pojo/JobConfigurationPOJOTest.java
+++ b/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/config/pojo/JobConfigurationPOJOTest.java
@@ -38,7 +38,7 @@ public final class JobConfigurationPOJOTest {
             + "jobName: test_job\n"
             + "jobParameter: param\n"
             + "jobShardingStrategyType: AVG_ALLOCATION\n"
-            + "maxTimeDiffSeconds: 0\n"
+            + "maxTimeDiffSeconds: -1\n"
             + "misfire: false\n"
             + "monitorExecution: false\n"
             + "overwrite: false\n"
@@ -52,7 +52,7 @@ public final class JobConfigurationPOJOTest {
             + "disabled: false\n"
             + "failover: false\n"
             + "jobName: test_job\n"
-            + "maxTimeDiffSeconds: 0\n"
+            + "maxTimeDiffSeconds: -1\n"
             + "misfire: false\n"
             + "monitorExecution: false\n"
             + "overwrite: false\n"
@@ -130,6 +130,7 @@ public final class JobConfigurationPOJOTest {
         actual.setShardingTotalCount(3);
         actual.setShardingItemParameters("0=A,1=B,2=C");
         actual.setJobParameter("param");
+        actual.setMaxTimeDiffSeconds(-1);
         actual.setJobShardingStrategyType("AVG_ALLOCATION");
         actual.setJobExecutorServiceHandlerType("CPU");
         actual.setJobErrorHandlerType("IGNORE");
@@ -144,6 +145,7 @@ public final class JobConfigurationPOJOTest {
         actual.setJobName("test_job");
         actual.setCron("0/1 * * * * ?");
         actual.setShardingTotalCount(3);
+        actual.setMaxTimeDiffSeconds(-1);
         assertThat(YamlEngine.marshal(actual), is(YAML_WITH_NULL));
     }