Re: svn commit: r8704 - in trunk: subversion/bindings/swig tools/examples

[Greg Stein <gs...@lyra.org>]

On Thu, Feb 19, 2004 at 12:55:04AM -0600, cmpilato@tigris.org wrote:
>...
> +/* Thunked version of svn_repos_authz_func_t callback type. */
> +svn_error_t *svn_swig_py_thunk_repos_authz_func(svn_boolean_t *allowed,
>...
> +  if ((result = PyObject_CallFunction(function, 
> +                                      (char *)"O&sO&", 
> +                                      make_ob_fs_root, root,
> +                                      path, make_ob_pool, pool)) != NULL)
> +    {
> +      if (result != Py_None)
> +        {
> +          if (PyInt_Check(result))
> +            *allowed = PyInt_AsLong(result);
> +          else if (PyLong_Check(result))
> +            *allowed = PyLong_AsLong(result);
> +          else
> +            err = convert_python_error();

Euh. There wouldn't be a Python error at this point. result is non-NULL
which implies no exception. You'll want to svn_error_create() something
here instead.

> +        }
> +      Py_DECREF(result);
> +      goto finished;

The goto and the target label are superfluous.

>...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org