You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/21 12:36:14 UTC
[GitHub] [arrow-rs] roee88 opened a new pull request #582: fix: undefined behavior in schema ffi
roee88 opened a new pull request #582:
URL: https://github.com/apache/arrow-rs/pull/582
Closes #580
# Rationale for this change
The undefined behavior that was fixed in #323 was re-introduced in #439.
This PR attempts to re-introduce the same fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #582: fix: undefined behavior in schema ffi
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #582:
URL: https://github.com/apache/arrow-rs/pull/582#issuecomment-884166062
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/582?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#582](https://codecov.io/gh/apache/arrow-rs/pull/582?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e5f4d1) into [master](https://codecov.io/gh/apache/arrow-rs/commit/e3d4c6a8bc7ff05ca5a26ee9669cf0a6717ede0c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3d4c6a) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 82.46% 82.45% -0.01%
==========================================
Files 167 167
Lines 46205 46205
==========================================
- Hits 38101 38100 -1
- Misses 8104 8105 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/582?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `87.07% <100.00%> (ø)` | |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/582/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `94.85% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/582?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/582?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d4c6a...7e5f4d1](https://codecov.io/gh/apache/arrow-rs/pull/582?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #582: fix: undefined behavior in schema ffi
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #582:
URL: https://github.com/apache/arrow-rs/pull/582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #582: fix: undefined behavior in schema ffi
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #582:
URL: https://github.com/apache/arrow-rs/pull/582#issuecomment-884185017
https://github.com/apache/arrow-rs/pull/582/checks?check_run_id=3123911024
Shows:
```
test result: ok. 89 passed; 0 failed; 0 ignored; 0 measured; 14 filtered out; finished in 12.50s
```
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #582: fix: undefined behavior in schema ffi
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #582:
URL: https://github.com/apache/arrow-rs/pull/582#issuecomment-884185198
Thank you so much @roee88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org