You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2011/10/12 22:11:28 UTC
svn commit: r1182566 -
/subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
Author: julianfoad
Date: Wed Oct 12 20:11:28 2011
New Revision: 1182566
URL: http://svn.apache.org/viewvc?rev=1182566&view=rev
Log:
On the 'tree-read-api' branch:
* subversion/libsvn_client/tree.c
(wc_tree_get_dir): Allocate results in the result pool not the scratch pool.
Found by: gstein
Modified:
subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
Modified: subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
URL: http://svn.apache.org/viewvc/subversion/branches/tree-read-api/subversion/libsvn_client/tree.c?rev=1182566&r1=1182565&r2=1182566&view=diff
==============================================================================
--- subversion/branches/tree-read-api/subversion/libsvn_client/tree.c (original)
+++ subversion/branches/tree-read-api/subversion/libsvn_client/tree.c Wed Oct 12 20:11:28 2011
@@ -332,7 +332,7 @@ wc_tree_get_dir(svn_client_tree_t *tree,
for (i = 0; i < children->nelts; i++)
{
const char *child_abspath = APR_ARRAY_IDX(children, i, const char *);
- const char *name = svn_dirent_basename(child_abspath, scratch_pool);
+ const char *name = svn_dirent_basename(child_abspath, result_pool);
apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, name);
}
Re: svn commit: r1182566 - /subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
Posted by Hyrum K Wright <hy...@wandisco.com>.
On Wed, Oct 12, 2011 at 3:39 PM, Julian Foad <ju...@wandisco.com> wrote:
> Hyrum K Wright wrote:
>> > Log:
>> > On the 'tree-read-api' branch:
>>
>> I would very much appreciate a BRANCH-README on this branch.
>
> Done just now, and on the 'showing-merge-info' branch also. Thanks for
> the prod.
Thanks! (And I hope my request didn't come off as a demand. It was
just a friendly prod.)
-Hyrum
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Re: svn commit: r1182566 -
/subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
Posted by Julian Foad <ju...@wandisco.com>.
Hyrum K Wright wrote:
> > Log:
> > On the 'tree-read-api' branch:
>
> I would very much appreciate a BRANCH-README on this branch.
Done just now, and on the 'showing-merge-info' branch also. Thanks for
the prod.
- Julian
Re: svn commit: r1182566 - /subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
Posted by Hyrum K Wright <hy...@wandisco.com>.
On Wed, Oct 12, 2011 at 3:11 PM, <ju...@apache.org> wrote:
> Author: julianfoad
> Date: Wed Oct 12 20:11:28 2011
> New Revision: 1182566
>
> URL: http://svn.apache.org/viewvc?rev=1182566&view=rev
> Log:
> On the 'tree-read-api' branch:
I would very much appreciate a BRANCH-README on this branch.
Thanks,
-Hyrum
>
> * subversion/libsvn_client/tree.c
> (wc_tree_get_dir): Allocate results in the result pool not the scratch pool.
>
> Found by: gstein
>
> Modified:
> subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
>
> Modified: subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
> URL: http://svn.apache.org/viewvc/subversion/branches/tree-read-api/subversion/libsvn_client/tree.c?rev=1182566&r1=1182565&r2=1182566&view=diff
> ==============================================================================
> --- subversion/branches/tree-read-api/subversion/libsvn_client/tree.c (original)
> +++ subversion/branches/tree-read-api/subversion/libsvn_client/tree.c Wed Oct 12 20:11:28 2011
> @@ -332,7 +332,7 @@ wc_tree_get_dir(svn_client_tree_t *tree,
> for (i = 0; i < children->nelts; i++)
> {
> const char *child_abspath = APR_ARRAY_IDX(children, i, const char *);
> - const char *name = svn_dirent_basename(child_abspath, scratch_pool);
> + const char *name = svn_dirent_basename(child_abspath, result_pool);
>
> apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, name);
> }
>
>
>
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Re: svn commit: r1182566 - /subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
Posted by Hyrum K Wright <hy...@wandisco.com>.
On Wed, Oct 12, 2011 at 3:11 PM, <ju...@apache.org> wrote:
> Author: julianfoad
> Date: Wed Oct 12 20:11:28 2011
> New Revision: 1182566
>
> URL: http://svn.apache.org/viewvc?rev=1182566&view=rev
> Log:
> On the 'tree-read-api' branch:
I would very much appreciate a BRANCH-README on this branch.
Thanks,
-Hyrum
>
> * subversion/libsvn_client/tree.c
> (wc_tree_get_dir): Allocate results in the result pool not the scratch pool.
>
> Found by: gstein
>
> Modified:
> subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
>
> Modified: subversion/branches/tree-read-api/subversion/libsvn_client/tree.c
> URL: http://svn.apache.org/viewvc/subversion/branches/tree-read-api/subversion/libsvn_client/tree.c?rev=1182566&r1=1182565&r2=1182566&view=diff
> ==============================================================================
> --- subversion/branches/tree-read-api/subversion/libsvn_client/tree.c (original)
> +++ subversion/branches/tree-read-api/subversion/libsvn_client/tree.c Wed Oct 12 20:11:28 2011
> @@ -332,7 +332,7 @@ wc_tree_get_dir(svn_client_tree_t *tree,
> for (i = 0; i < children->nelts; i++)
> {
> const char *child_abspath = APR_ARRAY_IDX(children, i, const char *);
> - const char *name = svn_dirent_basename(child_abspath, scratch_pool);
> + const char *name = svn_dirent_basename(child_abspath, result_pool);
>
> apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, name);
> }
>
>
>
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/