You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/05/11 12:45:08 UTC
Review Request 34036: LENS-546 : change parameter names to have _
instead of - in cli arg names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34036/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
change parameter names to have _ instead of - in cli arg names
Renamed parameters:
cube-name
fact-name
query-handle
prepare-handle
single-partition
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 095d70d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java d4b7418
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 818bd99
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
src/site/apt/user/cli.apt cbbc3eb
Diff: https://reviews.apache.org/r/34036/diff/
Testing
-------
Build with test cases - on top of LENS-544 changes.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.208 s]
[INFO] Lens ............................................... SUCCESS [ 2.569 s]
[INFO] Lens API ........................................... SUCCESS [ 17.472 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.529 s]
[INFO] Lens Cube .......................................... SUCCESS [02:49 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.385 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.145 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.647 s]
[INFO] Lens Server ........................................ SUCCESS [05:55 min]
[INFO] Lens client ........................................ SUCCESS [ 36.539 s]
[INFO] Lens CLI ........................................... SUCCESS [02:08 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.229 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.060 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.707 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.498 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:06 min
[INFO] Finished at: 2015-05-11T15:53:53+05:30
[INFO] Final Memory: 120M/380M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34036: LENS-546 : change parameter names to have _
instead of - in cli arg names
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34036/#review83570
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On May 12, 2015, 10:53 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34036/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 10:53 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> change parameter names to have _ instead of - in cli arg names
>
> Renamed parameters:
> cube-name
> dimension-name
> dimtable-name
> fact-name
> prepare-handle
> query-handle
> save-location
> storage-name
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 095d70d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java dc44f80
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java d4b7418
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 818bd99
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
> src/site/apt/user/cli.apt cbbc3eb
>
> Diff: https://reviews.apache.org/r/34036/diff/
>
>
> Testing
> -------
>
> Build with test cases - on top of LENS-544 changes.
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.208 s]
> [INFO] Lens ............................................... SUCCESS [ 2.569 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.472 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.529 s]
> [INFO] Lens Cube .......................................... SUCCESS [02:49 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.385 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.145 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.647 s]
> [INFO] Lens Server ........................................ SUCCESS [05:55 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.539 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:08 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.229 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.060 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.707 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.498 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:06 min
> [INFO] Finished at: 2015-05-11T15:53:53+05:30
> [INFO] Final Memory: 120M/380M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34036: LENS-546 : change parameter names to have _
instead of - in cli arg names
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34036/
-----------------------------------------------------------
(Updated May 12, 2015, 5:23 a.m.)
Review request for lens.
Changes
-------
Updated description.
Repository: lens
Description (updated)
-------
change parameter names to have _ instead of - in cli arg names
Renamed parameters:
cube-name
dimension-name
dimtable-name
fact-name
prepare-handle
query-handle
save-location
storage-name
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 095d70d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java dc44f80
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java d4b7418
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 818bd99
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
src/site/apt/user/cli.apt cbbc3eb
Diff: https://reviews.apache.org/r/34036/diff/
Testing
-------
Build with test cases - on top of LENS-544 changes.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.208 s]
[INFO] Lens ............................................... SUCCESS [ 2.569 s]
[INFO] Lens API ........................................... SUCCESS [ 17.472 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.529 s]
[INFO] Lens Cube .......................................... SUCCESS [02:49 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.385 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.145 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.647 s]
[INFO] Lens Server ........................................ SUCCESS [05:55 min]
[INFO] Lens client ........................................ SUCCESS [ 36.539 s]
[INFO] Lens CLI ........................................... SUCCESS [02:08 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.229 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.060 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.707 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.498 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:06 min
[INFO] Finished at: 2015-05-11T15:53:53+05:30
[INFO] Final Memory: 120M/380M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34036: LENS-546 : change parameter names to have _
instead of - in cli arg names
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34036/#review83354
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On May 11, 2015, 2:27 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34036/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 2:27 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> change parameter names to have _ instead of - in cli arg names
>
> Renamed parameters:
> cube-name
> fact-name
> query-handle
> prepare-handle
> single-partition
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 095d70d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java dc44f80
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java d4b7418
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 818bd99
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
> src/site/apt/user/cli.apt cbbc3eb
>
> Diff: https://reviews.apache.org/r/34036/diff/
>
>
> Testing
> -------
>
> Build with test cases - on top of LENS-544 changes.
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.208 s]
> [INFO] Lens ............................................... SUCCESS [ 2.569 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.472 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.529 s]
> [INFO] Lens Cube .......................................... SUCCESS [02:49 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.385 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.145 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.647 s]
> [INFO] Lens Server ........................................ SUCCESS [05:55 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.539 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:08 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.229 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.060 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.707 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.498 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:06 min
> [INFO] Finished at: 2015-05-11T15:53:53+05:30
> [INFO] Final Memory: 120M/380M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34036: LENS-546 : change parameter names to have _
instead of - in cli arg names
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34036/
-----------------------------------------------------------
(Updated May 11, 2015, 2:27 p.m.)
Review request for lens.
Repository: lens
Description
-------
change parameter names to have _ instead of - in cli arg names
Renamed parameters:
cube-name
fact-name
query-handle
prepare-handle
single-partition
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 095d70d
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java dc44f80
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java d4b7418
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 818bd99
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
src/site/apt/user/cli.apt cbbc3eb
Diff: https://reviews.apache.org/r/34036/diff/
Testing
-------
Build with test cases - on top of LENS-544 changes.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.208 s]
[INFO] Lens ............................................... SUCCESS [ 2.569 s]
[INFO] Lens API ........................................... SUCCESS [ 17.472 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.529 s]
[INFO] Lens Cube .......................................... SUCCESS [02:49 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.385 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.145 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.647 s]
[INFO] Lens Server ........................................ SUCCESS [05:55 min]
[INFO] Lens client ........................................ SUCCESS [ 36.539 s]
[INFO] Lens CLI ........................................... SUCCESS [02:08 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.229 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.060 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.707 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.498 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:06 min
[INFO] Finished at: 2015-05-11T15:53:53+05:30
[INFO] Final Memory: 120M/380M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 34036: LENS-546 : change parameter names to have _
instead of - in cli arg names
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34036/#review83215
-----------------------------------------------------------
I see hiphen some more keys which are not touched. Can you make sure they are all taken care?
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
<https://reviews.apache.org/r/34036/#comment134120>
still hiphen here?
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java
<https://reviews.apache.org/r/34036/#comment134119>
still hiphen here?
- Amareshwari Sriramadasu
On May 11, 2015, 10:45 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34036/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 10:45 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> change parameter names to have _ instead of - in cli arg names
>
> Renamed parameters:
> cube-name
> fact-name
> query-handle
> prepare-handle
> single-partition
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 095d70d
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java d4b7418
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 818bd99
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c0616d2
> src/site/apt/user/cli.apt cbbc3eb
>
> Diff: https://reviews.apache.org/r/34036/diff/
>
>
> Testing
> -------
>
> Build with test cases - on top of LENS-544 changes.
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.208 s]
> [INFO] Lens ............................................... SUCCESS [ 2.569 s]
> [INFO] Lens API ........................................... SUCCESS [ 17.472 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.529 s]
> [INFO] Lens Cube .......................................... SUCCESS [02:49 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.385 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.145 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.647 s]
> [INFO] Lens Server ........................................ SUCCESS [05:55 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.539 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:08 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.229 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.060 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.707 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.498 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:06 min
> [INFO] Finished at: 2015-05-11T15:53:53+05:30
> [INFO] Final Memory: 120M/380M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>