You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2017/08/20 08:25:57 UTC
[GitHub] metamodel-membrane pull request #6: METAMODEL-1150: Docker build (and a bit ...
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel-membrane/pull/6
METAMODEL-1150: Docker build (and a bit more)
I have been working on this PR to fix METAMODEL-1150. DockerHub will be doing builds like this only (without any maven pre-packaging steps):
```
docker build -t metamodel-membrane .
```
So the way the project is organized needed to support that. So with this PR, building the docker image now includes doing the maven build; a particular profile only which does not include all the tests and stuff. I figured that the tests would be better caught by Travis CI.
Now that the Docker build is working, I then started looking at integration tests. I built some using Postman and committed those too - I think they make a lot of sense and may also serve as examples for curious users.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel-membrane docker-build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel-membrane/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit 83a7e6f68320191f13a5b97cbea93ad6d440e6ee
Author: Kasper Sørensen <i....@gmail.com>
Date: 2017-08-20T08:14:16Z
Made docker build orchestrate everything (for DockerHub driven builds)
commit a6033aa5c13c696623ad0e279507da8d62458020
Author: Kasper Sørensen <i....@gmail.com>
Date: 2017-08-20T08:14:49Z
Added postman tests based on the setup created by docker-compose
commit 40d0564f1c60fdbc4871ea8599b8ed928ff2d2c3
Author: Kasper Sørensen <i....@gmail.com>
Date: 2017-08-20T08:15:12Z
Fixed issue in assigning database name when it shouldnt be set (CouchDB)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel-membrane issue #6: METAMODEL-1150: Docker build (and a bit more)
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel-membrane/pull/6
At work I have multiple projects where we have automated the postman runs. Also via Maven. The only issue is that it requires the `newman` tool installed on the build machine. Maybe we can set that up in Travis too, and then I think we have all we need.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel-membrane issue #6: METAMODEL-1150: Docker build (and a bit more)
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel-membrane/pull/6
Oh cool! That's perfect then ☺️
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel-membrane pull request #6: METAMODEL-1150: Docker build (and a bit ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel-membrane/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel-membrane issue #6: METAMODEL-1150: Docker build (and a bit more)
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the issue:
https://github.com/apache/metamodel-membrane/pull/6
Docker changes LGTM.
Regarding the Postman tests, I guess they're good in itself, but pretty useless as integration tests, unless you can find a way to make Travis run them.
Tests that you need to run manually are usually worth close to nothing, unless someone has a job description that says "you need to run these manually", which we are a bit low on in MetaModel :slightly_smiling_face:. Sooner or later they _will_ be obsolete and then they _will_ be ignored.
I guess we can merge as is, but I'd move to proper Maven+Junit integration tests ASAP (there's reasonably good tools for running a docker image using Maven that should also work with Travis, though I think we'll need make PG and Mongo Travis-run to stay within memory limits). I'll see if I can get a bit of time for implementing soon-ish.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---