[GitHub] [pulsar] eolivelli commented on a change in pull request #11963: [Issue #11799][logging] PIP-89: Enum based logging

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11963:
URL: https://github.com/apache/pulsar/pull/11963#discussion_r704297313



##########
File path: structured-event-log/src/main/java/org/apache/pulsar/structuredeventlog/slf4j/Slf4jEvent.java
##########
@@ -36,6 +39,9 @@
 import org.slf4j.LoggerFactory;
 
 class Slf4jEvent implements Event {
+    private static final ThreadLocal<Map<Object, Logger>> loggersTLS = ThreadLocal.withInitial(() -> new HashMap<>());
+    private static final Logger stringLogger = LoggerFactory.getLogger("stevlog");

Review comment:
       what about `org.apache.pulsar.structured.event.log` ?
   it is better that the logger name starts with "org.apache.pulsar", in order to let the users shutdown Pulsar stuff buy using only "org.apache.pulsar" prefix




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org