You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2015/07/16 16:53:52 UTC
[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/600
Coverity issues in OmniwireClassRegistry
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack coverity-omniwire
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #600
----
commit 81123a69dd31ea1d172fd625835782ca568c951f
Author: Daan Hoogland <da...@onecht.net>
Date: 2015-07-16T14:48:43Z
coverity 1116718: neglected jarinputstream when no entry found
commit 5aa85e30697d3d28232da5b75d80d01cc59f074a
Author: Daan Hoogland <da...@onecht.net>
Date: 2015-07-16T14:51:02Z
coverity 1116759: null pointer check before indexOf
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/600#discussion_r34869004
--- Diff: framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java ---
@@ -108,7 +107,7 @@ public void scan() {
while (resources.hasMoreElements()) {
String filePath = resources.nextElement().getFile();
// WINDOWS HACK
- if (filePath.indexOf("%20") > 0)
+ if (filePath != null && filePath.indexOf("%20") > 0)
--- End diff --
I didn't do that as there is a new assignment to the var in the if block. The replaceAll contract doesn't state a null retrun as possibiliy so I'll move the replaceAll inside the next if block if the rest of the flow allows it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/600#issuecomment-122014762
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/600#issuecomment-122225132
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/600#discussion_r34867930
--- Diff: framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java ---
@@ -108,7 +107,7 @@ public void scan() {
while (resources.hasMoreElements()) {
String filePath = resources.nextElement().getFile();
// WINDOWS HACK
- if (filePath.indexOf("%20") > 0)
+ if (filePath != null && filePath.indexOf("%20") > 0)
--- End diff --
There is already a filePath != null immediately below. The check can go inside that to avoid duplication.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/600#issuecomment-122246414
@DaanHoogland You can merge it I think
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---