You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Jordan Zimmerman <jo...@jordanzimmerman.com> on 2016/11/03 19:26:38 UTC
Jenkins issue
The pre-build for ZOOKEEPER-1525 is failing with this error. Any ideas?
BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580: 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of Findbugs installation> to Ant on the command-line.
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3511/console
Re: Jenkins issue
Posted by Michael Han <ha...@cloudera.com>.
Thanks Eddie for your analysis. Created PR 102
<https://github.com/apache/zookeeper/pull/102> just now that fixes all but
the ZooDefs warnings. We can start from there and decide what to do with
ZooDefs warnings.
On Mon, Nov 7, 2016 at 11:02 AM, Edward Ribeiro <ed...@gmail.com>
wrote:
> Hi folks,
>
> A cursory look at the new Findbug issues highlighted mostly trivial, and a
> subtle but drastic change (IMHO):
>
>
> 1. Dodgy code warnings
>
> * 3/4 of the cases spotted are due to the File.listFiles() method that
> could return null if the abstract pathname does not denote a directory or
> if an I/O error occurs. Probably it requires a:
>
> if (file.listFiles() != null etc) {
>
> More code verbosity, but doable, imo.
>
> * the remaining fourth case is at
> DeleteCommand.retainCompatibility(String[]) (line 62) where
> '
> newCmd' is created but never used. Trivial.
> ------------------------------------------------------------
> -----------------------------------------------------------------------
>
> 2. Performance warnings
>
> All of the cases are to replace this idiom
>
> for (K key : map.keySet()) {
> V value = map.getKey(key)
>
> with this one:
>
> for (Entry<K,V> e: map.entrySet()) {
>
> therefore, trivial change.
>
> ------------------------------------------------------------
> -----------------------------------------------------------------------
> 3.
> Malicious code vulnerability Warnings
>
> Findbugs is complaining because public or protected fields are mutable
> collections as bellow:
>
> public static final HashMap<Integer,String> map = new HashMap<>();
>
> The solution would be something along the lines of Map<Integer, String> map
> = Collections.unmodifiableMap(new HashMap<>());
>
> BUT this would break compatibility with ZooDefs.Ids.OPEN_ACL_UNSAFE and
> ZooDefs.Ids.READ_ACL_UNSAFE :((((
>
> The other mutable collections are used internally so I don't see any
> further problem using an non modifiable collection, but those ZooDefs.Ids
> fields can potentially break ZK clients into the wild. In fact, I commented
> about this a couple years ago:
> https://issues.apache.org/jira/browse/ZOOKEEPER-1362
>
> ------------------------------------------------------------
> -----------------------------------------------------------------------
>
> 4. Experimental Warnings
>
> Okay, I am totally unsure what we could alter here, but as far as I could
> understand it is complaining that an I/O error could potentially leak
> FileWriter, that is, it wants a:
>
> try {
> /.../
> }
> finally {
> if (file != null) {
> file.close();
> }
> }
>
> As far as I understood.
> ------------------------------------------------------------
> -----------------------------------------------------------------------
>
> So, all in all, my question is: what to do about
> ZooDefs.Ids.OPEN_ACL_UNSAFE and ZooDefs.Ids.OPEN_ACL_UNSAFE and
> ZooDefs.Ids.READ_ACL_UNSAFE, aka ZOOKEEPER-1362?
>
> Cheers,
> Edward
>
>
> On Sat, Nov 5, 2016 at 2:01 PM, Jordan Zimmerman <
> jordan@jordanzimmerman.com>
> wrote:
> >
> > Might as well fix the issues, merge to master and merge into the existing
> PRs. Then it will be done. Thoughts?
> >
> > -Jordan
>
--
Cheers
Michael.
Re: Jenkins issue
Posted by Edward Ribeiro <ed...@gmail.com>.
Hi folks,
A cursory look at the new Findbug issues highlighted mostly trivial, and a
subtle but drastic change (IMHO):
1. Dodgy code warnings
* 3/4 of the cases spotted are due to the File.listFiles() method that
could return null if the abstract pathname does not denote a directory or
if an I/O error occurs. Probably it requires a:
if (file.listFiles() != null etc) {
More code verbosity, but doable, imo.
* the remaining fourth case is at
DeleteCommand.retainCompatibility(String[]) (line 62) where
'
newCmd' is created but never used. Trivial.
-----------------------------------------------------------------------------------------------------------------------------------
2. Performance warnings
All of the cases are to replace this idiom
for (K key : map.keySet()) {
V value = map.getKey(key)
with this one:
for (Entry<K,V> e: map.entrySet()) {
therefore, trivial change.
-----------------------------------------------------------------------------------------------------------------------------------
3.
Malicious code vulnerability Warnings
Findbugs is complaining because public or protected fields are mutable
collections as bellow:
public static final HashMap<Integer,String> map = new HashMap<>();
The solution would be something along the lines of Map<Integer, String> map
= Collections.unmodifiableMap(new HashMap<>());
BUT this would break compatibility with ZooDefs.Ids.OPEN_ACL_UNSAFE and
ZooDefs.Ids.READ_ACL_UNSAFE :((((
The other mutable collections are used internally so I don't see any
further problem using an non modifiable collection, but those ZooDefs.Ids
fields can potentially break ZK clients into the wild. In fact, I commented
about this a couple years ago:
https://issues.apache.org/jira/browse/ZOOKEEPER-1362
-----------------------------------------------------------------------------------------------------------------------------------
4. Experimental Warnings
Okay, I am totally unsure what we could alter here, but as far as I could
understand it is complaining that an I/O error could potentially leak
FileWriter, that is, it wants a:
try {
/.../
}
finally {
if (file != null) {
file.close();
}
}
As far as I understood.
-----------------------------------------------------------------------------------------------------------------------------------
So, all in all, my question is: what to do about
ZooDefs.Ids.OPEN_ACL_UNSAFE and ZooDefs.Ids.OPEN_ACL_UNSAFE and
ZooDefs.Ids.READ_ACL_UNSAFE, aka ZOOKEEPER-1362?
Cheers,
Edward
On Sat, Nov 5, 2016 at 2:01 PM, Jordan Zimmerman <jo...@jordanzimmerman.com>
wrote:
>
> Might as well fix the issues, merge to master and merge into the existing
PRs. Then it will be done. Thoughts?
>
> -Jordan
Re: Jenkins issue
Posted by Raúl Gutiérrez Segalés <rg...@itevenworks.net>.
On 5 November 2016 at 10:21, Michael Han <ha...@cloudera.com> wrote:
> >> Might as well fix the issues
> +1. Created ZOOKEEPER-2628 for this task.
>
thanks Michael!
-rgs
Re: Jenkins issue
Posted by Michael Han <ha...@cloudera.com>.
>> Might as well fix the issues
+1. Created ZOOKEEPER-2628 for this task.
On Sat, Nov 5, 2016 at 9:01 AM, Jordan Zimmerman <jordan@jordanzimmerman.com
> wrote:
> Might as well fix the issues, merge to master and merge into the existing
> PRs. Then it will be done. Thoughts?
>
> -Jordan
>
> > On Nov 5, 2016, at 10:46 AM, Flavio P JUNQUEIRA <fp...@apache.org> wrote:
> >
> > What do you people think we should do, try the earlier version or try to
> > fix the issues with the latest findbugs?
> >
> > -Flavio
> >
> > On 4 Nov 2016 22:34, "Flavio Junqueira" <fp...@apache.org> wrote:
> >
> >> Got a response on the builds list:
> >>
> >>> Ok yes I upgraded Findbugs to 3.0.1
> >>>
> >>> Latest symlink was changed to point to that version.
> >>>
> >>> Maybe try changing from ‘latest’ to findbugs-2.0.3 and see if that
> >> ‘fixes’ things. (If so then for you, using the latest Findbugs has found
> >>> some problems?)
> >>>
> >>> Or, your build was caught in the middle cf the upgrade and things will
> >> work just fine now.
> >>>
> >>> Gav…
> >>
> >>
> >> So yes, it has been upgraded.
> >>
> >> -Flavio
> >>
> >>> On 04 Nov 2016, at 17:29, Flavio Junqueira <fp...@apache.org> wrote:
> >>>
> >>> Agreed, we should have a ticket to look into them, I'm not sure why we
> >> are getting those warnings. We got it even for ZK-2624, which should
> give
> >> us no warnings.
> >>>
> >>> I asked about findbugs on the builds list, but no one was able to tell
> >> me whether findbugs has been updated or not.
> >>>
> >>> -Flavio
> >>>
> >>>> On 04 Nov 2016, at 17:24, Michael Han <ha...@cloudera.com> wrote:
> >>>>
> >>>> I just noticed that in recent pre-commit builds, there are 19 - 20
> 'new'
> >>>> find bug warnings appear to at least three different JIRA issues:
> >>>>
> >>>> ZOOKEEPER-1621
> >>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
> >> 3513/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
> >>>>
> >>>> ZOOKEEPER-1525
> >>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
> >> 3515/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
> >>>>
> >>>> ZOOKEEPER-2014
> >>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
> >> 3516/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
> >>>>
> >>>> After triaging the warnings, I think most if not all the warnings are
> >> not
> >>>> caused by these patches as the code leads to the warnings is not
> >> touched by
> >>>> these patch. Maybe findbug tool is updated to a new version so it
> caught
> >>>> more issues? I guess we should try to fix these warnings in a separate
> >> jira
> >>>> if they are legitimate.
> >>>>
> >>>> On Thu, Nov 3, 2016 at 2:43 PM, Flavio Junqueira <fp...@apache.org>
> >> wrote:
> >>>>
> >>>>> The last 3 builds failed that way and nothing has changed as far as I
> >>>>> know. If it persists, we should open an infra ticket.
> >>>>>
> >>>>> -Flavio
> >>>>>
> >>>>>> On 03 Nov 2016, at 19:26, Jordan Zimmerman <
> >> jordan@jordanzimmerman.com>
> >>>>> wrote:
> >>>>>>
> >>>>>> The pre-build for ZOOKEEPER-1525 is failing with this error. Any
> >> ideas?
> >>>>>>
> >>>>>> BUILD FAILED
> >>>>>> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-
> >> Build/build.xml:1580:
> >>>>> 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of
> >>>>> Findbugs installation> to Ant on the command-line.
> >>>>>>
> >>>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
> 3511/console
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> Cheers
> >>>> Michael.
> >>>
> >>
> >>
>
>
--
Cheers
Michael.
Re: Jenkins issue
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
Might as well fix the issues, merge to master and merge into the existing PRs. Then it will be done. Thoughts?
-Jordan
> On Nov 5, 2016, at 10:46 AM, Flavio P JUNQUEIRA <fp...@apache.org> wrote:
>
> What do you people think we should do, try the earlier version or try to
> fix the issues with the latest findbugs?
>
> -Flavio
>
> On 4 Nov 2016 22:34, "Flavio Junqueira" <fp...@apache.org> wrote:
>
>> Got a response on the builds list:
>>
>>> Ok yes I upgraded Findbugs to 3.0.1
>>>
>>> Latest symlink was changed to point to that version.
>>>
>>> Maybe try changing from ‘latest’ to findbugs-2.0.3 and see if that
>> ‘fixes’ things. (If so then for you, using the latest Findbugs has found
>>> some problems?)
>>>
>>> Or, your build was caught in the middle cf the upgrade and things will
>> work just fine now.
>>>
>>> Gav…
>>
>>
>> So yes, it has been upgraded.
>>
>> -Flavio
>>
>>> On 04 Nov 2016, at 17:29, Flavio Junqueira <fp...@apache.org> wrote:
>>>
>>> Agreed, we should have a ticket to look into them, I'm not sure why we
>> are getting those warnings. We got it even for ZK-2624, which should give
>> us no warnings.
>>>
>>> I asked about findbugs on the builds list, but no one was able to tell
>> me whether findbugs has been updated or not.
>>>
>>> -Flavio
>>>
>>>> On 04 Nov 2016, at 17:24, Michael Han <ha...@cloudera.com> wrote:
>>>>
>>>> I just noticed that in recent pre-commit builds, there are 19 - 20 'new'
>>>> find bug warnings appear to at least three different JIRA issues:
>>>>
>>>> ZOOKEEPER-1621
>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
>> 3513/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>>>>
>>>> ZOOKEEPER-1525
>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
>> 3515/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>>>>
>>>> ZOOKEEPER-2014
>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
>> 3516/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>>>>
>>>> After triaging the warnings, I think most if not all the warnings are
>> not
>>>> caused by these patches as the code leads to the warnings is not
>> touched by
>>>> these patch. Maybe findbug tool is updated to a new version so it caught
>>>> more issues? I guess we should try to fix these warnings in a separate
>> jira
>>>> if they are legitimate.
>>>>
>>>> On Thu, Nov 3, 2016 at 2:43 PM, Flavio Junqueira <fp...@apache.org>
>> wrote:
>>>>
>>>>> The last 3 builds failed that way and nothing has changed as far as I
>>>>> know. If it persists, we should open an infra ticket.
>>>>>
>>>>> -Flavio
>>>>>
>>>>>> On 03 Nov 2016, at 19:26, Jordan Zimmerman <
>> jordan@jordanzimmerman.com>
>>>>> wrote:
>>>>>>
>>>>>> The pre-build for ZOOKEEPER-1525 is failing with this error. Any
>> ideas?
>>>>>>
>>>>>> BUILD FAILED
>>>>>> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-
>> Build/build.xml:1580:
>>>>> 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of
>>>>> Findbugs installation> to Ant on the command-line.
>>>>>>
>>>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3511/console
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Cheers
>>>> Michael.
>>>
>>
>>
Re: Jenkins issue
Posted by Flavio P JUNQUEIRA <fp...@apache.org>.
What do you people think we should do, try the earlier version or try to
fix the issues with the latest findbugs?
-Flavio
On 4 Nov 2016 22:34, "Flavio Junqueira" <fp...@apache.org> wrote:
> Got a response on the builds list:
>
> > Ok yes I upgraded Findbugs to 3.0.1
> >
> > Latest symlink was changed to point to that version.
> >
> > Maybe try changing from ‘latest’ to findbugs-2.0.3 and see if that
> ‘fixes’ things. (If so then for you, using the latest Findbugs has found
> > some problems?)
> >
> > Or, your build was caught in the middle cf the upgrade and things will
> work just fine now.
> >
> > Gav…
>
>
> So yes, it has been upgraded.
>
> -Flavio
>
> > On 04 Nov 2016, at 17:29, Flavio Junqueira <fp...@apache.org> wrote:
> >
> > Agreed, we should have a ticket to look into them, I'm not sure why we
> are getting those warnings. We got it even for ZK-2624, which should give
> us no warnings.
> >
> > I asked about findbugs on the builds list, but no one was able to tell
> me whether findbugs has been updated or not.
> >
> > -Flavio
> >
> >> On 04 Nov 2016, at 17:24, Michael Han <ha...@cloudera.com> wrote:
> >>
> >> I just noticed that in recent pre-commit builds, there are 19 - 20 'new'
> >> find bug warnings appear to at least three different JIRA issues:
> >>
> >> ZOOKEEPER-1621
> >> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
> 3513/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
> >>
> >> ZOOKEEPER-1525
> >> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
> 3515/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
> >>
> >> ZOOKEEPER-2014
> >> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/
> 3516/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
> >>
> >> After triaging the warnings, I think most if not all the warnings are
> not
> >> caused by these patches as the code leads to the warnings is not
> touched by
> >> these patch. Maybe findbug tool is updated to a new version so it caught
> >> more issues? I guess we should try to fix these warnings in a separate
> jira
> >> if they are legitimate.
> >>
> >> On Thu, Nov 3, 2016 at 2:43 PM, Flavio Junqueira <fp...@apache.org>
> wrote:
> >>
> >>> The last 3 builds failed that way and nothing has changed as far as I
> >>> know. If it persists, we should open an infra ticket.
> >>>
> >>> -Flavio
> >>>
> >>>> On 03 Nov 2016, at 19:26, Jordan Zimmerman <
> jordan@jordanzimmerman.com>
> >>> wrote:
> >>>>
> >>>> The pre-build for ZOOKEEPER-1525 is failing with this error. Any
> ideas?
> >>>>
> >>>> BUILD FAILED
> >>>> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-
> Build/build.xml:1580:
> >>> 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of
> >>> Findbugs installation> to Ant on the command-line.
> >>>>
> >>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3511/console
> >>>
> >>>
> >>
> >>
> >> --
> >> Cheers
> >> Michael.
> >
>
>
Re: Jenkins issue
Posted by Flavio Junqueira <fp...@apache.org>.
Got a response on the builds list:
> Ok yes I upgraded Findbugs to 3.0.1
>
> Latest symlink was changed to point to that version.
>
> Maybe try changing from ‘latest’ to findbugs-2.0.3 and see if that ‘fixes’ things. (If so then for you, using the latest Findbugs has found
> some problems?)
>
> Or, your build was caught in the middle cf the upgrade and things will work just fine now.
>
> Gav…
So yes, it has been upgraded.
-Flavio
> On 04 Nov 2016, at 17:29, Flavio Junqueira <fp...@apache.org> wrote:
>
> Agreed, we should have a ticket to look into them, I'm not sure why we are getting those warnings. We got it even for ZK-2624, which should give us no warnings.
>
> I asked about findbugs on the builds list, but no one was able to tell me whether findbugs has been updated or not.
>
> -Flavio
>
>> On 04 Nov 2016, at 17:24, Michael Han <ha...@cloudera.com> wrote:
>>
>> I just noticed that in recent pre-commit builds, there are 19 - 20 'new'
>> find bug warnings appear to at least three different JIRA issues:
>>
>> ZOOKEEPER-1621
>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3513/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>>
>> ZOOKEEPER-1525
>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3515/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>>
>> ZOOKEEPER-2014
>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3516/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>>
>> After triaging the warnings, I think most if not all the warnings are not
>> caused by these patches as the code leads to the warnings is not touched by
>> these patch. Maybe findbug tool is updated to a new version so it caught
>> more issues? I guess we should try to fix these warnings in a separate jira
>> if they are legitimate.
>>
>> On Thu, Nov 3, 2016 at 2:43 PM, Flavio Junqueira <fp...@apache.org> wrote:
>>
>>> The last 3 builds failed that way and nothing has changed as far as I
>>> know. If it persists, we should open an infra ticket.
>>>
>>> -Flavio
>>>
>>>> On 03 Nov 2016, at 19:26, Jordan Zimmerman <jo...@jordanzimmerman.com>
>>> wrote:
>>>>
>>>> The pre-build for ZOOKEEPER-1525 is failing with this error. Any ideas?
>>>>
>>>> BUILD FAILED
>>>> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580:
>>> 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of
>>> Findbugs installation> to Ant on the command-line.
>>>>
>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3511/console
>>>
>>>
>>
>>
>> --
>> Cheers
>> Michael.
>
Re: Jenkins issue
Posted by Flavio Junqueira <fp...@apache.org>.
Agreed, we should have a ticket to look into them, I'm not sure why we are getting those warnings. We got it even for ZK-2624, which should give us no warnings.
I asked about findbugs on the builds list, but no one was able to tell me whether findbugs has been updated or not.
-Flavio
> On 04 Nov 2016, at 17:24, Michael Han <ha...@cloudera.com> wrote:
>
> I just noticed that in recent pre-commit builds, there are 19 - 20 'new'
> find bug warnings appear to at least three different JIRA issues:
>
> ZOOKEEPER-1621
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3513/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>
> ZOOKEEPER-1525
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3515/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>
> ZOOKEEPER-2014
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3516/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
>
> After triaging the warnings, I think most if not all the warnings are not
> caused by these patches as the code leads to the warnings is not touched by
> these patch. Maybe findbug tool is updated to a new version so it caught
> more issues? I guess we should try to fix these warnings in a separate jira
> if they are legitimate.
>
> On Thu, Nov 3, 2016 at 2:43 PM, Flavio Junqueira <fp...@apache.org> wrote:
>
>> The last 3 builds failed that way and nothing has changed as far as I
>> know. If it persists, we should open an infra ticket.
>>
>> -Flavio
>>
>>> On 03 Nov 2016, at 19:26, Jordan Zimmerman <jo...@jordanzimmerman.com>
>> wrote:
>>>
>>> The pre-build for ZOOKEEPER-1525 is failing with this error. Any ideas?
>>>
>>> BUILD FAILED
>>> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580:
>> 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of
>> Findbugs installation> to Ant on the command-line.
>>>
>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3511/console
>>
>>
>
>
> --
> Cheers
> Michael.
Re: Jenkins issue
Posted by Michael Han <ha...@cloudera.com>.
I just noticed that in recent pre-commit builds, there are 19 - 20 'new'
find bug warnings appear to at least three different JIRA issues:
ZOOKEEPER-1621
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3513/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
ZOOKEEPER-1525
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3515/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
ZOOKEEPER-2014
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3516/artifact/build/test/findbugs/newPatchFindbugsWarnings.html
After triaging the warnings, I think most if not all the warnings are not
caused by these patches as the code leads to the warnings is not touched by
these patch. Maybe findbug tool is updated to a new version so it caught
more issues? I guess we should try to fix these warnings in a separate jira
if they are legitimate.
On Thu, Nov 3, 2016 at 2:43 PM, Flavio Junqueira <fp...@apache.org> wrote:
> The last 3 builds failed that way and nothing has changed as far as I
> know. If it persists, we should open an infra ticket.
>
> -Flavio
>
> > On 03 Nov 2016, at 19:26, Jordan Zimmerman <jo...@jordanzimmerman.com>
> wrote:
> >
> > The pre-build for ZOOKEEPER-1525 is failing with this error. Any ideas?
> >
> > BUILD FAILED
> > /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580:
> 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of
> Findbugs installation> to Ant on the command-line.
> >
> > https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3511/console
>
>
--
Cheers
Michael.
Re: Jenkins issue
Posted by Flavio Junqueira <fp...@apache.org>.
The last 3 builds failed that way and nothing has changed as far as I know. If it persists, we should open an infra ticket.
-Flavio
> On 03 Nov 2016, at 19:26, Jordan Zimmerman <jo...@jordanzimmerman.com> wrote:
>
> The pre-build for ZOOKEEPER-1525 is failing with this error. Any ideas?
>
> BUILD FAILED
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580: 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of Findbugs installation> to Ant on the command-line.
>
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3511/console