[GitHub] [superset] zhaoyongjie commented on a diff in pull request #22128: fix: SQLite dttm ISO format

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #22128:
URL: https://github.com/apache/superset/pull/22128#discussion_r1023416819


##########
superset/db_engine_specs/sqlite.py:
##########
@@ -82,7 +82,7 @@ def convert_dttm(
             utils.TemporalType.DATETIME,
             utils.TemporalType.TIMESTAMP,
         ):
-            return f"""'{dttm.isoformat(sep=" ", timespec="seconds")}'"""
+            return f"""'{dttm.isoformat(sep=" ", timespec="microseconds")}'"""

Review Comment:
   I remember that this line was fixed by [PR](https://github.com/apache/superset/pull/21113) because the SQLite manual said that _The datetime() function returns the date and time as text in their same formats: YYYY-MM-DD HH:MM:SS._([link](https://www.sqlite.org/lang_datefunc.html))
   
   So, please check out the previous PR and prevent introducing a regression. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org