You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/25 22:24:45 UTC
[GitHub] patrickmckenna commented on issue #2206: [AIRFLOW-922] Update
PrestoHook to enable synchronous execution
patrickmckenna commented on issue #2206: [AIRFLOW-922] Update PrestoHook to enable synchronous execution
URL: https://github.com/apache/airflow/pull/2206#issuecomment-457753176
I _think_ giving `PrestoHook.run` the ability to execute synchronously (and possibly even doing so by default) is still desired, missing functionality. If that isn't the case, please LMK and I'll close this PR.
For now, I've updated it to incorporate (most of) the latest commits on `apache:master`, and removed some of the earlier, stylistic changes that weren't strictly related to AIRFLOW-922.
I'm a bit confused by the partial test failures, which occur only on some Python 2 builds. Anyone else have insights here? (The test suite does seem a bit flaky—e.g. [this](https://travis-ci.org/apache/airflow/builds/484288872) is recent successful build of `apache/master`, but [a different build](https://travis-ci.com/patrickmckenna/airflow/builds/98656828) of the same [commit](https://github.com/apache/airflow/commit/993779f93df172f5f774f1ea2634c55e9c1212c4) partially failed—but I'm unsure if that's the root cause.)
/cc @SamWildmo @Rotemlofer (as interested users)
/cc @Fokko @kaxil @feng-tao (as maintainers who've touched `presto_hook` the most recently)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services