You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Martin van den Bemt <ml...@mvdb.net> on 2003/01/22 17:52:22 UTC
Re: cvs commit: jakarta-turbine-maven/src/plugins-build/ant
plugin.jelly
+1.
I tend to use maven and the "legacy" ant build (for eg gump and to see
if that one works too), which will need me to download the libs over and
over again (since the build.xml downloads everything in lib)
Mvgr,
Martin
On Wed, 2003-01-22 at 17:35, Morgan Delagrange wrote:
> Could someone roll back this change? Deleting a
> project's lib directory is too risky.
>
> - Morgan
>
> --- dion@apache.org wrote:
> > dion 2003/01/21 21:50:40
> >
> > Modified: src/plugins-build/ant plugin.jelly
> > Log:
> > Make clean target delete lib directory
> >
> > Revision Changes Path
> > 1.31 +1 -0
> >
> jakarta-turbine-maven/src/plugins-build/ant/plugin.jelly
> >
> > Index: plugin.jelly
> >
> >
> ===================================================================
> > RCS file:
> >
> /home/cvs/jakarta-turbine-maven/src/plugins-build/ant/plugin.jelly,v
> > retrieving revision 1.30
> > retrieving revision 1.31
> > diff -u -r1.30 -r1.31
> > --- plugin.jelly 19 Jan 2003 12:37:54 -0000 1.30
> > +++ plugin.jelly 22 Jan 2003 05:50:40 -0000 1.31
> > @@ -135,6 +135,7 @@
> > description="o Clean up the generated
> > directories">
> > <delete dir="$${defaulttargetdir}"/>
> > <delete dir="$${distdir}"/>
> > + <delete dir="lib"/>
> > </target>
> >
> > <target
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> >
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >
>
>
> =====
> Morgan Delagrange
> http://jakarta.apache.org/taglibs
> http://jakarta.apache.org/commons
> http://axion.tigris.org
> http://jakarta.apache.org/watchdog
>
> __________________________________________________
> Do you Yahoo!?
> Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
> http://mailplus.yahoo.com
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
Re: cvs commit: jakarta-turbine-maven/src/plugins-build/ant
plugin.jelly
Posted by Martin van den Bemt <ml...@mvdb.net>.
Works like a charm :) (tested on betwixt..)
We have to wait for someone else to commit it though, since I don't have
commit access ...
Mvgr,
Martin
On Wed, 2003-01-22 at 18:52, Morgan Delagrange wrote:
> Is the attached patch correct? I'm a Maven newbie.
> :)
>
Re: cvs commit: jakarta-turbine-maven/src/plugins-build/ant plugin.jelly
Posted by Morgan Delagrange <md...@yahoo.com>.
Is the attached patch correct? I'm a Maven newbie.
:)
- Morgan
--- Martin van den Bemt <ml...@mvdb.net> wrote:
> Damned.. I missed the clean :(
> Sorry for being blind..
> Like the target/lib solution though .. :)
>
> Mvgr,
> Martin
>
> On Wed, 2003-01-22 at 18:09, Morgan Delagrange
> wrote:
> > Actually, I like the fact that the "clean" task
> will
> > clean out the "lib" directory. This is essential
> for
> > automated processes like GUMP; otherwise the "lib"
> > directory will accumulate JAR versions without
> ever
> > cleaning house.
>
>
=====
Morgan Delagrange
http://jakarta.apache.org/taglibs
http://jakarta.apache.org/commons
http://axion.tigris.org
http://jakarta.apache.org/watchdog
__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com
Re: cvs commit: jakarta-turbine-maven/src/plugins-build/ant
plugin.jelly
Posted by Martin van den Bemt <ml...@mvdb.net>.
Damned.. I missed the clean :(
Sorry for being blind..
Like the target/lib solution though .. :)
Mvgr,
Martin
On Wed, 2003-01-22 at 18:09, Morgan Delagrange wrote:
> Actually, I like the fact that the "clean" task will
> clean out the "lib" directory. This is essential for
> automated processes like GUMP; otherwise the "lib"
> directory will accumulate JAR versions without ever
> cleaning house.
Re: cvs commit: jakarta-turbine-maven/src/plugins-build/ant plugin.jelly
Posted by James Strachan <ja...@yahoo.co.uk>.
From: "Morgan Delagrange" <md...@yahoo.com>
> Actually, I like the fact that the "clean" task will
> clean out the "lib" directory. This is essential for
> automated processes like GUMP; otherwise the "lib"
> directory will accumulate JAR versions without ever
> cleaning house.
>
> What I don't like is the LOCATION of the lib direcory.
> dIon and I talked about this and agreed that it's
> inappropriate to make any changes to "lib" directory,
> which projects may already use for other reasons;
> something like "target/lib" is much more reasonable.
> However he didn't get the chance to rollback the
> commit below. It needs to be fixed before users start
> to bootstrap this version, because they might
> accidentally blow away an important directory with
> this script.
+1. I think target/lib is a great idea.
It saves me adding lib to a .cvsignore whenever I stuble over it. Though
folks who do lots of 'ant clean' might get a bit fed up - though I guess we
could always let them overload this location.
James
-------
http://radio.weblogs.com/0112098/
__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com
Re: cvs commit: jakarta-turbine-maven/src/plugins-build/ant plugin.jelly
Posted by Morgan Delagrange <md...@yahoo.com>.
Actually, I like the fact that the "clean" task will
clean out the "lib" directory. This is essential for
automated processes like GUMP; otherwise the "lib"
directory will accumulate JAR versions without ever
cleaning house.
What I don't like is the LOCATION of the lib direcory.
dIon and I talked about this and agreed that it's
inappropriate to make any changes to "lib" directory,
which projects may already use for other reasons;
something like "target/lib" is much more reasonable.
However he didn't get the chance to rollback the
commit below. It needs to be fixed before users start
to bootstrap this version, because they might
accidentally blow away an important directory with
this script.
- Morgan
--- Martin van den Bemt <ml...@mvdb.net> wrote:
> +1.
> I tend to use maven and the "legacy" ant build (for
> eg gump and to see
> if that one works too), which will need me to
> download the libs over and
> over again (since the build.xml downloads
> everything in lib)
>
> Mvgr,
> Martin
>
> On Wed, 2003-01-22 at 17:35, Morgan Delagrange
> wrote:
> > Could someone roll back this change? Deleting a
> > project's lib directory is too risky.
> >
> > - Morgan
> >
> > --- dion@apache.org wrote:
> > > dion 2003/01/21 21:50:40
> > >
> > > Modified: src/plugins-build/ant
> plugin.jelly
> > > Log:
> > > Make clean target delete lib directory
> > >
> > > Revision Changes Path
> > > 1.31 +1 -0
> > >
> >
>
jakarta-turbine-maven/src/plugins-build/ant/plugin.jelly
> > >
> > > Index: plugin.jelly
> > >
> > >
> >
>
===================================================================
> > > RCS file:
> > >
> >
>
/home/cvs/jakarta-turbine-maven/src/plugins-build/ant/plugin.jelly,v
> > > retrieving revision 1.30
> > > retrieving revision 1.31
> > > diff -u -r1.30 -r1.31
> > > --- plugin.jelly 19 Jan 2003 12:37:54 -0000
> 1.30
> > > +++ plugin.jelly 22 Jan 2003 05:50:40 -0000
> 1.31
> > > @@ -135,6 +135,7 @@
> > > description="o Clean up the generated
> > > directories">
> > > <delete dir="$${defaulttargetdir}"/>
> > > <delete dir="$${distdir}"/>
> > > + <delete dir="lib"/>
> > > </target>
> > >
> > > <target
> > >
> > >
> > >
> > >
> > > --
> > > To unsubscribe, e-mail:
> > >
> >
>
<ma...@jakarta.apache.org>
> > > For additional commands, e-mail:
> > >
> <ma...@jakarta.apache.org>
> > >
> >
> >
> > =====
> > Morgan Delagrange
> > http://jakarta.apache.org/taglibs
> > http://jakarta.apache.org/commons
> > http://axion.tigris.org
> > http://jakarta.apache.org/watchdog
> >
> > __________________________________________________
> > Do you Yahoo!?
> > Yahoo! Mail Plus - Powerful. Affordable. Sign up
> now.
> > http://mailplus.yahoo.com
> >
> > --
> > To unsubscribe, e-mail:
>
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
> >
>
>
>
> --
> To unsubscribe, e-mail:
>
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
=====
Morgan Delagrange
http://jakarta.apache.org/taglibs
http://jakarta.apache.org/commons
http://axion.tigris.org
http://jakarta.apache.org/watchdog
__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com