You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ma...@apache.org on 2009/02/17 14:12:24 UTC
svn commit: r745039 -
/myfaces/trinidad/tags/trinidad-1.2.11/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputTextRenderer.java
Author: matzew
Date: Tue Feb 17 13:12:23 2009
New Revision: 745039
URL: http://svn.apache.org/viewvc?rev=745039&view=rev
Log:
TRINIDAD-1390 - maximumLength generates onKeyUp JavaScript even if value is <= 0
only render JS when we have a positive maxLength
Modified:
myfaces/trinidad/tags/trinidad-1.2.11/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputTextRenderer.java
Modified: myfaces/trinidad/tags/trinidad-1.2.11/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputTextRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/tags/trinidad-1.2.11/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputTextRenderer.java?rev=745039&r1=745038&r2=745039&view=diff
==============================================================================
--- myfaces/trinidad/tags/trinidad-1.2.11/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputTextRenderer.java (original)
+++ myfaces/trinidad/tags/trinidad-1.2.11/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputTextRenderer.java Tue Feb 17 13:12:23 2009
@@ -529,11 +529,11 @@
String onKeyUp = super.getOnkeyup(bean);
if (isTextArea(bean))
{
- Number maxLength = getMaximumLength(bean);
- if (maxLength != null)
+ Number maximumLength = getMaximumLength(bean);
+ if(maximumLength != null && maximumLength.intValue()> 0)
{
onKeyUp = _getMaxLengthFunction(onKeyUp,
- maxLength.intValue());
+ maximumLength.intValue());
}
}
@@ -600,7 +600,7 @@
if (isTextArea(bean))
{
Number maxLength = getMaximumLength(bean);
- if (maxLength != null)
+ if (maxLength != null && maxLength.intValue()> 0)
{
onchange = _getMaxLengthFunction(onchange,
maxLength.intValue());