You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Zhao Yongming (Created) (JIRA)" <ji...@apache.org> on 2011/11/24 04:18:41 UTC
[jira] [Created] (TS-1031) reduce lock in netHandler and reduce the
possiblity of acquiring expire server sessions
reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions
---------------------------------------------------------------------------------------
Key: TS-1031
URL: https://issues.apache.org/jira/browse/TS-1031
Project: Traffic Server
Issue Type: Improvement
Components: Core
Affects Versions: 3.1.1
Reporter: Zhao Yongming
Assignee: weijin
Priority: Minor
reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions. put your patch here for review :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1031) reduce lock in netHandler and reduce the
possiblity of acquiring expire server sessions
Posted by "Alan M. Carroll (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-1031:
--------------------------------
Attachment: (was: ts-1031.diff)
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions
> ---------------------------------------------------------------------------------------
>
> Key: TS-1031
> URL: https://issues.apache.org/jira/browse/TS-1031
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: weijin
> Priority: Minor
>
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions. put your patch here for review :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1031) reduce lock in netHandler and reduce the
possiblity of acquiring expire server sessions
Posted by "Zhao Yongming (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhao Yongming updated TS-1031:
------------------------------
Fix Version/s: (was: 3.1.4)
3.3.0
I think the patch should not be required after we fix the do_io_close issue, let us focus on other enhancement later.
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions
> ---------------------------------------------------------------------------------------
>
> Key: TS-1031
> URL: https://issues.apache.org/jira/browse/TS-1031
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: weijin
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ts-1031.diff
>
>
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions. put your patch here for review :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1031) reduce lock in netHandler and reduce the
possiblity of acquiring expire server sessions
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1031:
------------------------------
Fix Version/s: 3.1.4
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions
> ---------------------------------------------------------------------------------------
>
> Key: TS-1031
> URL: https://issues.apache.org/jira/browse/TS-1031
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: weijin
> Priority: Minor
> Fix For: 3.1.4
>
> Attachments: ts-1031.diff
>
>
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions. put your patch here for review :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1031) reduce lock in netHandler and reduce the
possiblity of acquiring expire server sessions
Posted by "Alan M. Carroll (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-1031:
--------------------------------
Attachment: ts-1031.diff
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions
> ---------------------------------------------------------------------------------------
>
> Key: TS-1031
> URL: https://issues.apache.org/jira/browse/TS-1031
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: weijin
> Priority: Minor
> Attachments: ts-1031.diff
>
>
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions. put your patch here for review :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1031) reduce lock in netHandler and reduce
the possiblity of acquiring expire server sessions
Posted by "John Plevyak (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166654#comment-13166654 ]
John Plevyak commented on TS-1031:
----------------------------------
I don't understand why this is necessary. Nobody should call do_io_close() until they have cleared ALL pointers to the NetVC. This seems like a hack to prevent buggy code from crashing in this particular way rather than just doing other bad things (including crashing in some other way).
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions
> ---------------------------------------------------------------------------------------
>
> Key: TS-1031
> URL: https://issues.apache.org/jira/browse/TS-1031
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: weijin
> Priority: Minor
> Attachments: ts-1031.diff
>
>
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions. put your patch here for review :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1031) reduce lock in netHandler and reduce the
possiblity of acquiring expire server sessions
Posted by "Alan M. Carroll (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-1031:
--------------------------------
Attachment: ts-1031.diff
A patch that is a major revision to the previous efforts.
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions
> ---------------------------------------------------------------------------------------
>
> Key: TS-1031
> URL: https://issues.apache.org/jira/browse/TS-1031
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: weijin
> Priority: Minor
> Attachments: ts-1031.diff
>
>
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions. put your patch here for review :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1031) reduce lock in netHandler and reduce
the possiblity of acquiring expire server sessions
Posted by "Alan M. Carroll (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159343#comment-13159343 ]
Alan M. Carroll commented on TS-1031:
-------------------------------------
This is something of a hack.
Longer term what would be better is to separate IO closure with re-allocation. If we used something like Ptr (from lib/ts/Ptr.h) to reference count and not put the VC back on the free list until the last reference clears, then this would be far less of a problem. It is plausible that everything crash has happened after a VC was free'd rather than just closed.
The one issue would be cross thread freeing, although that should not be a problem unless there is a consistent drift of VCs to a single thread, although it might be that VCs are really freed when the thread local free list grows too large in which case this is just not maximally efficient.
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions
> ---------------------------------------------------------------------------------------
>
> Key: TS-1031
> URL: https://issues.apache.org/jira/browse/TS-1031
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.1.1
> Reporter: Zhao Yongming
> Assignee: weijin
> Priority: Minor
> Attachments: ts-1031.diff
>
>
> reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions. put your patch here for review :D
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira